Skip to content

images center-block doesn't work #19339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XhmikosR opened this issue Feb 28, 2016 · 4 comments
Closed

images center-block doesn't work #19339

XhmikosR opened this issue Feb 28, 2016 · 4 comments
Labels
css v4
Milestone
v4.0.0-alpha.3

Comments

@XhmikosR
Copy link
Member

Just opening this to investigate it later

screen shot 2016-02-28 at 03 54 28

Firefox 45b10 x64, Windows 7 x64

/CC @cvrebert @mdo
@XhmikosR XhmikosR added the v4 label Feb 28, 2016
@cvrebert cvrebert added the css label Feb 28, 2016
@alberto
Copy link
Contributor

alberto commented Feb 28, 2016

.center-block was replaced by .m-x-auto. The latter doesn't set display:block while the former did, so they are not really equivalent.

@cvrebert
Copy link
Collaborator

If we add the display utilities requested in #19254, we could just tack the display:block utility class onto that example.

@XhmikosR XhmikosR mentioned this issue Mar 11, 2016
Closed
@XhmikosR XhmikosR added this to the v4.0.0-alpha.3 milestone Mar 11, 2016
@RyanZim
Copy link

RyanZim commented Apr 6, 2016

a0a157d should have fixed this.

cvrebert added a commit that referenced this issue Apr 7, 2016
@cvrebert
Update lingering implicit prose reference to .center-block
835676b 
Closes #19339
Refs #19102, #19443, #19665
[skip sauce]
@cvrebert
Copy link
Collaborator

cvrebert commented Apr 7, 2016

@RyanZim Indeed! But there was one lingering erratum that's now been fixed by 835676b.

@cvrebert cvrebert closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
4 participants
@alberto @XhmikosR @cvrebert @RyanZim