Skip to content

add vi #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add vi #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/src/main/res/values-vi/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,14 @@
<string name="enable_media_buttons">Bật nút phương tiện</string>
<string name="import_presets_successful">Nhập các thiết lập trước từ tệp thành công!</string>
<string name="export_presets_successful">Xuất các thiết lập trước ra tệp thành công!</string>
<string name="app_copyright">2019–21 Tác giả Noice</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright notice should be preserved in LICENSE's language (en).

<string name="plus1m">1p</string>
<string name="plus5m">5p</string>
<string name="plus30m">30p</string>
<string name="plus1h">1g</string>
<string name="plus4h">4h</string>
<string name="plus8h">8g</string>
Comment on lines +193 to +198
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time qualifiers were marked as non-translatable since '1h and 1m' are considerably popular notations, as compared to their localised variants.

<string name="others_key">khác</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a shared preference key to identify the "others" category. The actual string's translation already existed.

<string name="v2_announcement_title">Thông báo v2</string>
<string name="v2_announcement_message">Chúng tôi đang thực hiện một số thay đổi căn bản đối với Noice. Vui lòng đọc thêm về chúng [here] (https://ashutoshgngwr.github.io/noice/news/v2-announcement?ref=Android+App)!</string>
Comment on lines +200 to +201
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 announcement will naturally be removed in the next release, and hence it was marked as non-translatable.

</resources>
50 changes: 25 additions & 25 deletions app/src/main/res/values/donottranslate.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire file was already marked as 'do not translate'. AGP automatically considers files named donottranslate.xml as non-translatable.

http://tools.android.com/recent/non-translatablestrings

<resources>
<string name="app_name">Noice</string>
<string name="app_name" translatable="false">Noice</string>
<string name="app_copyright">2019–21 the Noice Authors</string>
<string name="app_license_url">https://github.com/ashutoshgngwr/noice/blob/master/LICENSE</string>
<string name="app_authors_url">https://ashutoshgngwr.github.io/noice/contributors?ref=Android+App</string>
<string name="app_changelog_url">https://ashutoshgngwr.github.io/noice/CHANGELOG?ref=Android+App</string>
<string name="app_website_url">https://ashutoshgngwr.github.io/noice?ref=Android+App</string>
<string name="app_instagram_url">https://www.instagram.com/trynoice/</string>
<string name="app_twitter_url">https://twitter.com/trynoice</string>
<string name="app_github_url">https://github.com/ashutoshgngwr/noice</string>
<string name="app_issues_github_url">https://github.com/ashutoshgngwr/noice/issues</string>
<string name="app_issues_form_url">
<string name="app_license_url" translatable="false">https://github.com/ashutoshgngwr/noice/blob/master/LICENSE</string>
<string name="app_authors_url" translatable="false">https://ashutoshgngwr.github.io/noice/contributors?ref=Android+App</string>
<string name="app_changelog_url" translatable="false">https://ashutoshgngwr.github.io/noice/CHANGELOG?ref=Android+App</string>
<string name="app_website_url" translatable="false">https://ashutoshgngwr.github.io/noice?ref=Android+App</string>
<string name="app_instagram_url" translatable="false">https://www.instagram.com/trynoice/</string>
<string name="app_twitter_url" translatable="false">https://twitter.com/trynoice</string>
<string name="app_github_url" translatable="false">https://github.com/ashutoshgngwr/noice</string>
<string name="app_issues_github_url" translatable="false">https://github.com/ashutoshgngwr/noice/issues</string>
<string name="app_issues_form_url" translatable="false">
https://docs.google.com/forms/d/e/1FAIpQLSdYhyYjxhJ7IKyiqdc3AE3uINSoRWBw8ROB003gkZ47KeSjWw/viewform?usp=sf_link
</string>
<string name="feedback_form_url">
<string name="feedback_form_url" translatable="false">
https://docs.google.com/forms/d/e/1FAIpQLSdEfOCyWfQ4QFMnLqlLj3BF27VKS1C-CQIokbmkXFchf6QZ6g/viewform?usp=sf_link
</string>
<string name="plus1m">1m</string>
Expand All @@ -22,21 +22,21 @@
<string name="plus1h">1h</string>
<string name="plus4h">4h</string>
<string name="plus8h">8h</string>
<string name="presets_as_home_screen_key">pref_saved_presets_as_homescreen</string>
<string name="sound_fade_duration_key">sound_fade_duration</string>
<string name="sound_fade_in_duration_key">sound_fade_in_duration</string>
<string name="app_theme_key">app_theme</string>
<string name="ignore_audio_focus_changes_key">ignore_audio_focus_changes</string>
<string name="import_presets_key">import_presets</string>
<string name="export_presets_key">export_presets</string>
<string name="remove_all_app_shortcuts_key">remove_all_app_shortcuts</string>
<string name="should_display_sound_icons_key">should_display_sound_icons</string>
<string name="presets_as_home_screen_key" translatable="false">pref_saved_presets_as_homescreen</string>
<string name="sound_fade_duration_key" translatable="false">sound_fade_duration</string>
<string name="sound_fade_in_duration_key" translatable="false">sound_fade_in_duration</string>
<string name="app_theme_key" translatable="false">app_theme</string>
<string name="ignore_audio_focus_changes_key" translatable="false">ignore_audio_focus_changes</string>
<string name="import_presets_key" translatable="false">import_presets</string>
<string name="export_presets_key" translatable="false">export_presets</string>
<string name="remove_all_app_shortcuts_key" translatable="false">remove_all_app_shortcuts</string>
<string name="should_display_sound_icons_key" translatable="false">should_display_sound_icons</string>
<string name="others_key">others</string>
<string name="should_share_usage_data_key">should_share_usage_data</string>
<string name="enable_media_buttons_key">enable_media_buttons</string>
<string name="open_collective_url">https://opencollective.com/noice</string>
<string name="play_store_url">https://play.google.com/store/apps/details?id=com.github.ashutoshgngwr.noice</string>
<string name="fdroid_url">https://f-droid.org/app/com.github.ashutoshgngwr.noice</string>
<string name="should_share_usage_data_key" translatable="false">should_share_usage_data</string>
<string name="enable_media_buttons_key" translatable="false">enable_media_buttons</string>
<string name="open_collective_url" translatable="false">https://opencollective.com/noice</string>
<string name="play_store_url" translatable="false">https://play.google.com/store/apps/details?id=com.github.ashutoshgngwr.noice</string>
<string name="fdroid_url" translatable="false">https://f-droid.org/app/com.github.ashutoshgngwr.noice</string>
<string name="v2_announcement_title">v2 Announcement</string>
<string name="v2_announcement_message">We are making some radical changes to Noice. Please read more about them [here](https://ashutoshgngwr.github.io/noice/news/v2-announcement?ref=Android+App)!</string>
</resources>