-
-
Notifications
You must be signed in to change notification settings - Fork 94
add vi #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vi #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't take notice earlier, but it appears that the vi
translation was already at 100%. I cannot accept the translations that you've suggested, since all of these were marked as non-translatable.
@@ -1,19 +1,19 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire file was already marked as 'do not translate'. AGP automatically considers files named donottranslate.xml
as non-translatable.
<string name="v2_announcement_title">Thông báo v2</string> | ||
<string name="v2_announcement_message">Chúng tôi đang thực hiện một số thay đổi căn bản đối với Noice. Vui lòng đọc thêm về chúng [here] (https://ashutoshgngwr.github.io/noice/news/v2-announcement?ref=Android+App)!</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2 announcement will naturally be removed in the next release, and hence it was marked as non-translatable.
<string name="plus1h">1g</string> | ||
<string name="plus4h">4h</string> | ||
<string name="plus8h">8g</string> | ||
<string name="others_key">khác</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a shared preference key to identify the "others" category. The actual string's translation already existed.
<string name="plus1m">1p</string> | ||
<string name="plus5m">5p</string> | ||
<string name="plus30m">30p</string> | ||
<string name="plus1h">1g</string> | ||
<string name="plus4h">4h</string> | ||
<string name="plus8h">8g</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time qualifiers were marked as non-translatable since '1h and 1m' are considerably popular notations, as compared to their localised variants.
@@ -189,4 +189,14 @@ | |||
<string name="enable_media_buttons">Bật nút phương tiện</string> | |||
<string name="import_presets_successful">Nhập các thiết lập trước từ tệp thành công!</string> | |||
<string name="export_presets_successful">Xuất các thiết lập trước ra tệp thành công!</string> | |||
<string name="app_copyright">2019–21 Tác giả Noice</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright notice should be preserved in LICENSE's language (en).
Changes
Add Vietnamese language
Testing