Ninth dec changes merge in master #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for parentAccount property * Now with tests! And cleaned up the code * Slight cleanup of effectivePubID() * Further refinement to effectivePubID()
* tappx bidder base * Tappx Bidder v1.0 * added host parameter * tappx endpoint to macros * tappx bidder v1.0 final * fix formatting * added list of adapters without syncer * requested fixes
* going out real quick, brb * brb to attend 395 * Test cases still not ready, but touching base to see if we are on the right track here * removed some commented lines * Counting Imp types inside go_metrics.RecordImps function * Added >0 check in go_metrics.RecordImps * working on the prometheus part * going out real quick * Finally working as a counterVector for banner. Replicate for the others * Prometheus implemented * Test case for RecordImps() function * refactored imp types to be boolean values inside a new ImpLabels type * refactoring prometheus.go * Hans' refactoring and RecordLegacyImps() implemented * corrected .travis.yml * trying to fix travis issue * Small changes after Mansi's review
…in bid request (prebid#968) * Omitempty on 'Target json.RawMessage' to avoid sending invalid in bid request * Omit empty additional fields
-Added null cj=hecks for Site and App -Added required fields validation: Site: id or page, App: id or bundle
* Initial changes * OneMobile adapter implementation * Updated the MakeRequests func for OneMobileAdapter * Fix race tests for onemobile adapter * Review updates and rename to verizonmedia * Fixed formated file * Review comments update * Review comments update seatbid length check
* new mgid adapter * increase coverage * remove extra imports * [mgid] optional placementId
* ignore swp files * start small * start really small * add a user sync * justify * triplelift adapter * add our endpoint * fix syntax * config stuff * compiler fixes * more config * add params * making progress * make our ext more exty * start making responses * more logic * fix compilation errors * can we just nil this out? * augment our json * radically simplify our json * fix errs * infer the bid type * fix syntax * fix comilation errors * rename * fix compilation error * config stuff * simplify params * more config stuff * fixes * revert this * fix up the extension * getting closer * add a test * update config * update bidder params * add the floor here, too * add a usersync test * validation, ws, and a test * update tests * fix test * update email * why not * change email * preprocess requests * do some parsing * take care of some errors * floor is optional * ws * remove native * everything is either banner or video * this should be a float * floor to floor * fix compilation errors * add some tests * more tests * more tests * simplify * more progress * format * ws * rm * don't need this * fix test * fix test * don't ignore swap * change line back * report an error if there are no valid impressions for triplelift * check for either a Banner or Video object on the impression * more tests * mv * more tests
* added tappx bidder doc * tappx doc revision
…#983) * Shift the metrics collection rate from one datapoint every 10 seconds to one every 20 * rolling back histogram change * some prometheus research * InfluxDB changes only
Do not forward imp.id as imp.tagId
Couple things here and there
Setup `Rev` field name into the comment so it's properly interpreted by godoc
* add zeroclickfraud adapter * fixes for PR * fix casing of Zeroclickfraud
* Added adform info file * Added Adform adapter and bidder * Updates from master * Removed usersyncInfo from Adform adapter. Inverted Imp type check. * Removed excessive loop * Updated with the last master * Create readme file for adform * Fix Adform's parameters regex Motivation: catastrophic backtracking during regex execution Details: - https://regex101.com/r/NNQrWq/1 - string to check "url_domain:keskustelu.suomi24.fi,url_path:/matkailu/matkakohteet/aasia,layout:lg,categories:Matkailu,main_category:Matkailu" Co-authored-by: v.statkevich <[email protected]> Co-authored-by: Olga Linkevich <[email protected]>
…from header (prebid#1219) * If Device.UA is not present in request body, init it with user-agent from request header if it's present * Moved User-Agent handler to parseVideoRequest func and added unit test * Minor clean up Co-authored-by: Veronika Solovei <[email protected]>
Co-authored-by: Veronika Solovei <[email protected]>
Co-authored-by: Ryan Haksi <[email protected]>
Fix type
Fix typo.
* WIP added logging to cache for video endpoint * Updating cache call to use TTL from config * Updates from initial feedback * Log now includes HTTP headers * Fixed caching to use a new cache entry rather than appending to the VAST * Added feature where is query is set, the test flag is set in the request * Updated recorded response and handleError * Updates from code review comments * Changed recorded output to be only the debug ext * Removed extra marhal calls * Changed cache to be an endpoint dependency * Added debugLog struct to hold all debug related info * Numerous smaller changes * Further code cleanup and added unit tests for debug changes * Added missing error checks * Added unit test for error case
Co-authored-by: Aadesh Patel <[email protected]>
* First pass at phase 1 TCF 2.0 support * minor fixes * Update go-gdpr library and fix stuff * Fixes for PR comments
Co-authored-by: Aadesh Patel <[email protected]>
also edited all examples so they include the full openRTB context
* nanointeractive adapter * nanointeractive adapter, changes after review * nanointeractive adapter * nanointeractive adapter, changes after review * formatting
* Fix Typo * Fixed More Typos
Brand Name Vender list id Consent string email corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.