Omit empty on 'Target json.RawMessage' to avoid sending invalid json in bid request #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansinahar
previously approved these changes
Jul 19, 2019
guscarreon
reviewed
Jul 19, 2019
| @@ -53,7 +53,7 @@ type rubiconImpExtRPTrack struct { | |||
|
|
|||
There was a problem hiding this comment.
Are Inventory and Visitor not necessary to omit if empty?
40 type rubiconParams struct {
41 AccountId int `json:"accountId"`
42 SiteId int `json:"siteId"`
43 ZoneId int `json:"zoneId"`
44 Inventory json.RawMessage `json:"inventory"`
45 Visitor json.RawMessage `json:"visitor"`
46 Video rubiconVideoParams `json:"video"`
47 }
48
adapters/rubicon/rubicon.go
There was a problem hiding this comment.
Forgot a few lines. Thank you.
mansinahar
approved these changes
Jul 19, 2019
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
…in bid request (prebid#968) * Omitempty on 'Target json.RawMessage' to avoid sending invalid in bid request * Omit empty additional fields
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
…in bid request (prebid#968) * Omitempty on 'Target json.RawMessage' to avoid sending invalid in bid request * Omit empty additional fields
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
…in bid request (prebid#968) * Omitempty on 'Target json.RawMessage' to avoid sending invalid in bid request * Omit empty additional fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a target was not provided for the Rubicon adapter then it's value is set to an empty string which is invalid json. Resulting in an invalid request. Omitting the field if it's empty fixes this issue.
#967