Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch.stream stores resource_version for the next call #89

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Jan 13, 2020

The method Watch.Stream stores a resource version to use in the next calls if the first hasn't returned another value.

Fixes #77

@codecov-io
Copy link

Codecov Report

Merging #89 into master will increase coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   93.54%   93.55%   +0.01%     
==========================================
  Files          23       23              
  Lines        1533     1551      +18     
==========================================
+ Hits         1434     1451      +17     
- Misses         99      100       +1
Impacted Files Coverage Δ
kubernetes_asyncio/watch/watch.py 93.4% <100%> (+0.14%) ⬆️
kubernetes_asyncio/watch/watch_test.py 95.65% <93.75%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a12bd...4ae6b9d. Read the comment docs.

@tomplus tomplus merged commit aef9edc into master Jan 14, 2020
@tomplus tomplus deleted the feat/stream_res_version branch February 26, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watching with specified resource_version
2 participants