Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watching with specified resource_version #77

Closed
TrueBrain opened this issue Jul 6, 2019 · 1 comment · Fixed by #89
Closed

Watching with specified resource_version #77

TrueBrain opened this issue Jul 6, 2019 · 1 comment · Fixed by #89
Labels
enhancement New feature or request

Comments

@TrueBrain
Copy link

Currently when you start a stream() (on a Watch()) with a specific resource_version, the retry after a timeout fails if no new events arrived.

This has been solved in kubernetes-client with:
kubernetes-client/python-base@2d69e89

Having this added to kubernetes_asyncio would be really useful, although a workaround is also pretty simple (create the Watch() object and set resource_version there too before calling stream()). But this is a bit of a hack ;)

I tried to backport this myself, but got hopefully lost in the test case.
@tomplus tomplus added the enhancement New feature or request label Jul 7, 2019
@tomplus
Copy link
Owner

tomplus commented Jul 7, 2019

@TrueBrain Thanks for spotting this. Please try to add it if you can. I'll help you with tests.

@tomplus tomplus mentioned this issue Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: watch.stream stores resource_version for the next call tomplus/kubernetes_asyncio
2 participants
@tomplus @TrueBrain