Skip to content

코드 리팩토링 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 27, 2022
Merged

코드 리팩토링 #17

merged 9 commits into from
Jan 27, 2022

Conversation

soilSpoon
Copy link
Member

@soilSpoon soilSpoon commented Jan 11, 2022

  • packge.json 조정
  • 코드 정리
  • 메인페이지 인풋 자동 포커스 구현
  • 사용자 편의성을 위해 input 영역 조정(padding 사용)
    • 백그라운드 이미지 배치한 것처럼 input을 백그라우드로 두고 검색 버튼을 위로 올려서 영역을 더 넓혀도 괜찮을 것 같습니다.
  • fix(utils): atomWithStorage should deal with no localStorage pmndrs/jotai#951 PR 내용이 릴리즈 되어야 jotai 버전을 1.5.1로 올릴 수 있을 것 같습니다.
    • 1.5.2로 배포되어 해당 버전으로 올렸습니다.

@soilSpoon soilSpoon requested a review from jaeinbaek January 11, 2022 05:30
@vercel
Copy link

vercel bot commented Jan 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/15gg/15gg/26oTNPRa1D4xffk28fqUBj8n6dcH
✅ Preview: https://15gg-git-fork-soilspoon-refactor-15gg.vercel.app

jaeinbaek
jaeinbaek previously approved these changes Jan 12, 2022
@soilSpoon soilSpoon merged commit f81f320 into to15gg:main Jan 27, 2022
@soilSpoon soilSpoon deleted the refactor branch January 27, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants