Skip to content

fix(utils): atomWithStorage should deal with no localStorage #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 11, 2022

close #949

This was caused by my addition of deprecation warning in #934.

@vercel
Copy link

vercel bot commented Jan 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/9hjLNHRaKS4Btc3fMC1iLFZdsvmY
✅ Preview: https://jotai-git-fix-issue-949-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 912b0b5:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

Size Change: +66 B (0%)

Total Size: 96.6 kB

Filename Size Change
dist/esm/utils.js 4.73 kB +14 B (0%)
dist/system/utils.js 5.05 kB +15 B (0%)
dist/umd/utils.js 6.11 kB +17 B (0%)
dist/utils.js 5.93 kB +20 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/plugin-react-refresh.js 947 B
dist/babel/preset.js 1.21 kB
dist/devtools.js 3.26 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/plugin-react-refresh.js 763 B
dist/esm/babel/preset.js 1.01 kB
dist/esm/devtools.js 2.48 kB
dist/esm/immer.js 616 B
dist/esm/index.js 5.27 kB
dist/esm/optics.js 661 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.49 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 1.13 kB
dist/esm/zustand.js 284 B
dist/immer.js 732 B
dist/index.js 6.05 kB
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/system/babel/plugin-debug-label.js 723 B
dist/system/babel/plugin-react-refresh.js 866 B
dist/system/babel/preset.js 1.11 kB
dist/system/devtools.js 2.67 kB
dist/system/immer.js 739 B
dist/system/index.js 5.55 kB
dist/system/optics.js 765 B
dist/system/query.js 1.4 kB
dist/system/redux.js 339 B
dist/system/urql.js 1.64 kB
dist/system/valtio.js 639 B
dist/system/xstate.js 1.25 kB
dist/system/zustand.js 372 B
dist/umd/babel/plugin-debug-label.js 932 B
dist/umd/babel/plugin-react-refresh.js 1.08 kB
dist/umd/babel/preset.js 1.34 kB
dist/umd/devtools.js 3.4 kB
dist/umd/immer.js 875 B
dist/umd/index.js 6.21 kB
dist/umd/optics.js 1.08 kB
dist/umd/query.js 1.5 kB
dist/umd/redux.js 449 B
dist/umd/urql.js 1.69 kB
dist/umd/valtio.js 719 B
dist/umd/xstate.js 1.33 kB
dist/umd/zustand.js 473 B
dist/urql.js 1.54 kB
dist/valtio.js 586 B
dist/xstate.js 1.19 kB
dist/zustand.js 344 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Next.js @ jotai 1.5.1] atomWithStorage : localStorage is not defined
1 participant