Skip to content

Move prepared statement queries to shared tests #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

svenklemm
Copy link
Member

No description provided.

@svenklemm svenklemm requested a review from cevian November 4, 2019 11:57
Copy link
Contributor

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't tsl/test/shared/expected/constraint_exclusion_prepared.out have some output?

@svenklemm svenklemm force-pushed the compression12 branch 2 times, most recently from 2af05d8 to 4a0e75e Compare November 5, 2019 14:45
@svenklemm svenklemm force-pushed the compression12 branch 3 times, most recently from 3eb63b3 to 9ef1cff Compare November 6, 2019 17:56
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b2918e5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1516   +/-   ##
=========================================
  Coverage          ?   91.47%           
=========================================
  Files             ?      144           
  Lines             ?    21443           
  Branches          ?        0           
=========================================
  Hits              ?    19615           
  Misses            ?     1828           
  Partials          ?        0
Flag Coverage Δ
#cron 89.56% <100%> (?)
#pr 91.82% <100%> (?)
Impacted Files Coverage Δ
tsl/src/nodes/decompress_chunk/decompress_chunk.c 92.59% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2918e5...1d2b719. Read the comment docs.

@svenklemm svenklemm force-pushed the compression12 branch 3 times, most recently from 32f4683 to 320cab3 Compare November 7, 2019 11:24
The construct used for pushing down produces a warning on certain
older compiler, so while it was correct this patch changes it to
get rid of the warning and to prevent introducing an imbalance later.
Ignore results of bgw_db_scheduler test because it is not reliable.
This patch moves the prepared statement test to the shared tests so
they can be run on compressed hypertables as well.
@svenklemm svenklemm merged commit 6fe5ef3 into timescale:master Nov 7, 2019
@cevian cevian added this to the 1.6.0 milestone Jan 8, 2020
@svenklemm svenklemm deleted the compression12 branch April 18, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants