Skip to content

Refactor bad-mannered things #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/scenario_simulator_exception/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<test_depend>ament_cmake_clang_format</test_depend>
<test_depend>ament_cmake_copyright</test_depend>
Expand Down
1 change: 1 addition & 0 deletions common/simple_junit/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<depend>pugixml-dev</depend>
<depend>boost</depend>
Expand Down
4 changes: 4 additions & 0 deletions common/status_monitor/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@
<description>none</description>
<maintainer email="[email protected]">Tatsuya Yamasaki</maintainer>
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<depend>boost</depend>
<depend>nlohmann-json-dev</depend>

<export>
<build_type>ament_cmake</build_type>
</export>
Expand Down
2 changes: 0 additions & 2 deletions map/kashiwanoha_map/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@
<buildtool_depend>ament_cmake</buildtool_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_cmake_clang_format</test_depend>
<test_depend>ament_cmake_copyright</test_depend>
<test_depend>ament_cmake_lint_cmake</test_depend>
<test_depend>ament_cmake_pep257</test_depend>
<test_depend>ament_cmake_xmllint</test_depend>

<export>
Expand Down
2 changes: 0 additions & 2 deletions map/simple_cross_map/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@
<buildtool_depend>ament_cmake</buildtool_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_cmake_clang_format</test_depend>
<test_depend>ament_cmake_copyright</test_depend>
<test_depend>ament_cmake_lint_cmake</test_depend>
<test_depend>ament_cmake_pep257</test_depend>
<test_depend>ament_cmake_xmllint</test_depend>

<export>
Expand Down
1 change: 1 addition & 0 deletions mock/cpp_mock_scenarios/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<buildtool_export_depend>ament_cmake_test</buildtool_export_depend>

Expand Down
1 change: 1 addition & 0 deletions openscenario/openscenario_experimental_catalog/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<description>TIER IV experimental catalogs for OpenSCENARIO</description>
<maintainer email="[email protected]">Tatsuya Yamasaki</maintainer>
<license>Apache License 2.0</license>
<buildtool_depend>ament_cmake</buildtool_depend>
<export>
<build_type>ament_cmake</build_type>
</export>
Expand Down
1 change: 1 addition & 0 deletions openscenario/openscenario_interpreter/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<depend>concealer</depend>
<depend>geometry_msgs</depend>
Expand Down
1 change: 1 addition & 0 deletions openscenario/openscenario_interpreter_example/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<depend>autoware_system_msgs</depend>
<depend>boost</depend>
Expand Down
3 changes: 2 additions & 1 deletion openscenario/openscenario_interpreter_msgs/package.xml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>openscenario_interpreter_msgs</name>
<version>16.5.11</version>
<description>ROS message types for package openscenario_interpreter</description>
<maintainer email="[email protected]">Yamasaki Tatsuya</maintainer>
<license>Apache License 2.0</license>
<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>
<buildtool_depend>rosidl_default_generators</buildtool_depend>
<depend>builtin_interfaces</depend>
<depend>rosidl_default_runtime</depend>
Expand Down
4 changes: 2 additions & 2 deletions openscenario/openscenario_preprocessor_msgs/package.xml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>openscenario_preprocessor_msgs</name>
<version>16.5.11</version>
<description>ROS message types for package openscenario_preprocessor</description>
<maintainer email="[email protected]">Kotaro Yoshimoto</maintainer>
<license>Apache License 2.0</license>
<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>
<buildtool_depend>rosidl_default_generators</buildtool_depend>
<depend>builtin_interfaces</depend>
<depend>rosidl_default_runtime</depend>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__DETECTION_SENSOR__DETECTION_SENSOR_HPP_
#define SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__DETECTION_SENSOR__DETECTION_SENSOR_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <geometry/plane.hpp>
#include <geometry_msgs/msg/pose.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__IMU_SENSOR_HPP_
#define SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__IMU_SENSOR_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <array>
#include <geometry_msgs/msg/accel.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__LIDAR__LIDAR_SENSOR_HPP_
#define SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__LIDAR__LIDAR_SENSOR_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <agnocast_wrapper/agnocast_wrapper.hpp>
#include <geometry/quaternion/get_rotation_matrix.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__OCCUPANCY_GRID__OCCUPANCY_GRID_SENSOR_HPP_
#define SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__OCCUPANCY_GRID__OCCUPANCY_GRID_SENSOR_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <memory>
#include <nav_msgs/msg/occupancy_grid.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__PRIMITIVES__BOX_HPP_
#define SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__PRIMITIVES__BOX_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <simple_sensor_simulator/sensor_simulation/primitives/primitive.hpp>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__SENSOR_SIMULATION_HPP_
#define SIMPLE_SENSOR_SIMULATOR__SENSOR_SIMULATION__SENSOR_SIMULATION_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <agnocast_wrapper/agnocast_wrapper.hpp>
#include <autoware_perception_msgs/msg/detected_objects.hpp>
Expand Down
1 change: 1 addition & 0 deletions simulation/simple_sensor_simulator/package.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>simple_sensor_simulator</name>
<version>16.5.11</version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMPLE_SENSOR_SIMULATOR__TEST__UTILS__HELPER_FUNCTIONS_HPP_
#define SIMPLE_SENSOR_SIMULATOR__TEST__UTILS__HELPER_FUNCTIONS_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <cmath>
#include <geometry_msgs/msg/point.hpp>
Expand Down
21 changes: 17 additions & 4 deletions simulation/simulation_interface/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,23 @@ set(PROTO_FILES
"proto/std_msgs.proto"
"proto/traffic_simulator_msgs.proto"
)
protobuf_generate_cpp(PROTO_SRCS PROTO_HDRS ${PROTO_FILES})
set(PROTO_OUTPUT_DIR ${CMAKE_BINARY_DIR}/proto/${PROJECT_NAME})

# Ensure the output directory exists
file(MAKE_DIRECTORY ${PROTO_OUTPUT_DIR})

protobuf_generate(
PROTOS ${PROTO_FILES}
APPEND_PATH
LANGUAGE cpp
OUT_VAR PROTO_SRCS
IMPORT_DIRS proto/
PROTOC_OUT_DIR ${PROTO_OUTPUT_DIR}
)

include_directories(
include
${CMAKE_BINARY_DIR}
${CMAKE_BINARY_DIR}/proto/
)

ament_auto_add_library(simulation_interface SHARED
Expand All @@ -60,8 +73,8 @@ install(TARGETS simulation_interface
INCLUDES DESTINATION include)

install(
FILES ${PROTO_HDRS}
DESTINATION include
DIRECTORY ${CMAKE_BINARY_DIR}/proto/
DESTINATION include/
)

install(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
#ifndef SIMULATION_INTERFACE__CONVERSIONS_HPP_
#define SIMULATION_INTERFACE__CONVERSIONS_HPP_

#include <builtin_interfaces.pb.h>
#include <geometry_msgs.pb.h>
#include <rosgraph_msgs.pb.h>
#include <simulation_api_schema.pb.h>
#include <std_msgs.pb.h>
#include <traffic_simulator_msgs.pb.h>
#include <simulation_interface/builtin_interfaces.pb.h>
#include <simulation_interface/geometry_msgs.pb.h>
#include <simulation_interface/rosgraph_msgs.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>
#include <simulation_interface/std_msgs.pb.h>
#include <simulation_interface/traffic_simulator_msgs.pb.h>

#include <autoware_control_msgs/msg/control.hpp>
#include <autoware_vehicle_msgs/msg/gear_command.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMULATION_INTERFACE__ZMQ_MULTI_CLIENT_HPP_
#define SIMULATION_INTERFACE__ZMQ_MULTI_CLIENT_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <functional>
#include <iostream>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef SIMULATION_INTERFACE__ZMQ_MULTI_SERVER_HPP_
#define SIMULATION_INTERFACE__ZMQ_MULTI_SERVER_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <functional>
#include <rclcpp/rclcpp.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
#ifndef SIMULATION_INTERFACE__TEST__EXPECT_EQUAL_MACROS_HPP_
#define SIMULATION_INTERFACE__TEST__EXPECT_EQUAL_MACROS_HPP_

#include <geometry_msgs.pb.h>
#include <gtest/gtest.h>
#include <simulation_interface/geometry_msgs.pb.h>

#include <geometry_msgs/msg/accel.hpp>
#include <geometry_msgs/msg/point.hpp>
Expand Down
2 changes: 1 addition & 1 deletion simulation/simulation_interface/test/test_conversions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <geometry_msgs.pb.h>
#include <gtest/gtest.h>
#include <simulation_interface/geometry_msgs.pb.h>

#include "expect_equal_macros.hpp"
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef TRAFFIC_SIMULATOR__API__API_HPP_
#define TRAFFIC_SIMULATOR__API__API_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <simulation_interface/conversions.hpp>
#include <simulation_interface/zmq_multi_client.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef TRAFFIC_SIMULATOR__HELPER__HELPER_HPP_
#define TRAFFIC_SIMULATOR__HELPER__HELPER_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <algorithm>
#include <cmath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef TRAFFIC_SIMULATOR__TRAFFIC_LIGHTS__TRAFFIC_LIGHT_HPP_
#define TRAFFIC_SIMULATOR__TRAFFIC_LIGHTS__TRAFFIC_LIGHT_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <color_names/color_names.hpp>
#include <cstdint>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef TRAFFIC_SIMULATOR__TRAFFIC_LIGHTS__TRAFFIC_LIGHTS_BASE_HPP_
#define TRAFFIC_SIMULATOR__TRAFFIC_LIGHTS__TRAFFIC_LIGHTS_BASE_HPP_

#include <simulation_api_schema.pb.h>
#include <simulation_interface/simulation_api_schema.pb.h>

#include <memory>
#include <rclcpp/rclcpp.hpp>
Expand Down
1 change: 1 addition & 0 deletions simulation/traffic_simulator/package.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>traffic_simulator</name>
<version>16.5.11</version>
Expand Down
1 change: 1 addition & 0 deletions test_runner/random_test_runner/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_auto</buildtool_depend>

<depend>traffic_simulator</depend>
<depend>simple_sensor_simulator</depend>
Expand Down
Loading