Skip to content

Refactor bad-mannered things #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactor bad-mannered things #1631

wants to merge 7 commits into from

Conversation

f0reachARR
Copy link
Contributor

Description

Abstract

This PR introduces several improvements and fixes:

  1. Isolated Protobuf output into project-specific directories.
    1. Updated include paths for simulation_api_schema.pb.h to use simulation_interface/.
  2. Added ament_cmake_auto as a required dependency where it was originally necessary but missing.
  3. Removed unused test dependencies.

Details

Protobuf Output Isolation

  • Protobuf-generated files are now output to ${CMAKE_BINARY_DIR}/proto/${PROJECT_NAME} instead of root include/.
  • Added file(MAKE_DIRECTORY ...) to ensure the output directory exists before generation.

Addition of ament_cmake_auto

  • Added ament_cmake_auto to package.xml files where it was originally required but missing.

Removal of Unused Test Dependencies

  • Removed unused test dependencies such as ament_cmake_clang_format and ament_cmake_pep257 from package.xml files of static map packages.

Destructive Changes

Users of simulation_api_schema.pb.h should prepend simulation_interface/.

Copy link

github-actions bot commented Jun 19, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test labels Jun 19, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants