Refactor bad-mannered things #1631
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR introduces several improvements and fixes:
simulation_api_schema.pb.h
to usesimulation_interface/
.ament_cmake_auto
as a required dependency where it was originally necessary but missing.Details
Protobuf Output Isolation
${CMAKE_BINARY_DIR}/proto/${PROJECT_NAME}
instead of rootinclude/
.file(MAKE_DIRECTORY ...)
to ensure the output directory exists before generation.Addition of
ament_cmake_auto
ament_cmake_auto
topackage.xml
files where it was originally required but missing.Removal of Unused Test Dependencies
ament_cmake_clang_format
andament_cmake_pep257
frompackage.xml
files of static map packages.Destructive Changes
Users of
simulation_api_schema.pb.h
should prependsimulation_interface/
.