Skip to content

fix: add missing MiscObjectBehavior when calling spawn api #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

lchojnack
Copy link
Contributor

@lchojnack lchojnack commented May 8, 2025

Description

This fix resolves the following issue:

  • MiscObject NPC is not spawning in AWSIM ss2

Abstract

Resolves the issue where the MicsObject NPC is not spawning in AWSIM ss2

Background

None

Details

In the latest master ( commit 8f2c212 from May 2025), there is 1 common spawn API for

  • vehicle, pedestrian and miscObject (takes 5 arguments) → code link

image

For that reason when the API is called in applyAddEntityAction() with 4 arguments for MiscObject (code link), the model3d is passed as the 4th behavior argument , and the 5th model3d argument is taken the default one, so it is the empty string "".

image

Finally, the ss2 sends the request to AWSIM to spawn the entity with model3d which is "".

References

https://tier4.atlassian.net/browse/RJD-1774

Destructive Changes

None

Known Limitations

None

Copy link

github-actions bot commented May 8, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@lchojnack lchojnack self-assigned this May 8, 2025
@lchojnack lchojnack added bug Something isn't working waiting for CI bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels May 8, 2025
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
Copy link
Contributor Author

There is no regression

@lchojnack lchojnack marked this pull request as ready for review May 9, 2025 12:21
@yamacir-kit yamacir-kit self-requested a review May 14, 2025 02:13
Copy link

@yamacir-kit yamacir-kit merged commit 9c47b85 into master May 15, 2025
15 checks passed
@github-actions github-actions bot deleted the fix/mics-objects-model3d branch May 15, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 waiting for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants