Skip to content

fix(docs): use architecture_type:=awf/universe/20250130 #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 18, 2025

Conversation

dmoszynski
Copy link
Contributor

@dmoszynski dmoszynski commented Apr 15, 2025

Description

Abstract

Updated the value of the architecture_type argument passed in the example run commands in the documentation.

Background

It is preffeered to specify awf/universe/20250130 as the launch argument architecture_type.
For more details, see #1518.

Details

Changed from:

  • architecture_type:=awf/universe/20230906

to

  • architecture_type:=awf/universe/20250130

Updated files:

  • docs/developer_guide/Communication.md
  • docs/user_guide/QuickStart.md
  • docs/user_guide/random_test_runner/QuickStart.md
  • docs/user_guide/random_test_runner/Usage.md
  • docs/user_guide/scenario_test_runner/RealtimeFactor.md

References

RJD-1681

Destructive Changes

None

Known Limitations

None

Copy link

github-actions bot commented Apr 15, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@dmoszynski dmoszynski added documentation Improvements or additions to documentation bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Apr 15, 2025
@dmoszynski
Copy link
Contributor Author

dmoszynski commented Apr 17, 2025

@HansRobo
Thank you so much for your suggestions for changes and your comments. 🙇
I would like to admit that I made the changes without checking the content itself, which resulted in them being applied where they should not have been.. I deeply apologize for the omissions and unexpected (and simply wrong...) changes.
I've already corrected everything (I hope..). 🙇

@HansRobo HansRobo marked this pull request as ready for review April 18, 2025 08:59
@HansRobo HansRobo merged commit 3dc7d04 into master Apr 18, 2025
8 checks passed
@github-actions github-actions bot deleted the docs/fix_architecture_type branch April 18, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants