Skip to content

Refactor/concealer 7 #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 28, 2025
Merged

Refactor/concealer 7 #1549

merged 16 commits into from
Mar 28, 2025

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Mar 14, 2025

Description

Abstract

Added new struct concealer::LegacyAutowareState.

Background

The Autoware development team has notified us that the /autoware/state topic is deprecated. As a replacement, per-module states are now provided by Autoware. This allows for a more detailed state of Autoware. However, the old AutowareState is still useful to simulators for its simplicity. Therefore, we have combined the states per module to reproduce the old AutowareState internally.

Details

None.

References

Destructive Changes

None.

Known Limitations

None.

@yamacir-kit yamacir-kit added refactor bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Mar 14, 2025
@yamacir-kit yamacir-kit self-assigned this Mar 14, 2025
Copy link

github-actions bot commented Mar 14, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@yamacir-kit yamacir-kit requested a review from HansRobo March 27, 2025 09:14
@yamacir-kit yamacir-kit marked this pull request as ready for review March 27, 2025 09:14
Copy link

Failure optional scenarios

Note

This is an experimental check and does not block merging the pull-request.
But, please be aware that this may indicate a regression.

scenario failed: execution_time_test
      <failure type="SimulationFailure" message="CustomCommandAction typed &quot;exitFailure&quot; was triggered by the named Conditions {&quot;update time checker&quot;, &quot;avoid startup&quot;}: {&quot;update time checker&quot;: Is the /simulation/interpreter/execution_time/update (= 0.005740000000000000310307335383) is greaterThan 0.005?}, {&quot;avoid startup&quot;: Is the simulation time (= 10.550000000000014921397450962104) is greaterThan 1.000000000000000000000000000000?}" />

Copy link

sonarqubecloud bot commented Mar 27, 2025

@yamacir-kit yamacir-kit merged commit 4094abd into master Mar 28, 2025
15 checks passed
@github-actions github-actions bot deleted the refactor/concealer-7 branch March 28, 2025 05:02
@yamacir-kit yamacir-kit mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants