-
Notifications
You must be signed in to change notification settings - Fork 61
Refactor/concealer 7 #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor/concealer 7 #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…ating `Storyboard.Init` Signed-off-by: yamacir-kit <[email protected]>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…tor/concealer-7 Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…reState Signed-off-by: yamacir-kit <[email protected]>
… to `waiting_for_route` Signed-off-by: yamacir-kit <[email protected]>
Signed-off-by: yamacir-kit <[email protected]>
…ion in comment Signed-off-by: yamacir-kit <[email protected]>
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.005740000000000000310307335383) is greaterThan 0.005?}, {"avoid startup": Is the simulation time (= 10.550000000000014921397450962104) is greaterThan 1.000000000000000000000000000000?}" /> |
|
HansRobo
approved these changes
Mar 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Added new struct
concealer::LegacyAutowareState
.Background
The Autoware development team has notified us that the
/autoware/state
topic is deprecated. As a replacement, per-module states are now provided by Autoware. This allows for a more detailed state of Autoware. However, the old AutowareState is still useful to simulators for its simplicity. Therefore, we have combined the states per module to reproduce the old AutowareState internally.Details
None.
References
Destructive Changes
None.
Known Limitations
None.