Skip to content

feat: Add missing .NET modules #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

HofmeisterAn
Copy link
Contributor

The PR adds the following missing .NET modules to the Community Module Registry:

  • ClickHouse
  • CockroachDb
  • Consul
  • FakeGcsServer
  • InfluxDb
  • Nats

I also removed the --version option from the installation command. I believe it's unnecessary since the CLI will automatically install the latest available version, which is probably what we want anyway.

There are still a few modules left that I don't think exist in any other language. I created an issue in the Testcontainers for .NET repository, maybe someone from the community will pick it up. If not, I can take care of it from time to time: testcontainers/testcontainers-dotnet#1372.

@HofmeisterAn HofmeisterAn requested a review from a team as a code owner February 15, 2025 09:54
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Feb 17, 2025
@mdelapenya mdelapenya merged commit 06afa16 into main Feb 17, 2025
1 check passed
@mdelapenya mdelapenya deleted the feature/add-missing-dotnet-modules branch February 17, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants