Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add missing .NET modules to the Community Module Registry #1372

Open
8 of 12 tasks
HofmeisterAn opened this issue Feb 15, 2025 · 12 comments · Fixed by #1411
Open
8 of 12 tasks

[Enhancement]: Add missing .NET modules to the Community Module Registry #1372

HofmeisterAn opened this issue Feb 15, 2025 · 12 comments · Fixed by #1411
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups enhancement New feature or request help wanted Extra attention is needed

Comments

@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Feb 15, 2025

Problem

I believe the following .NET modules are not listed in the Community Module Registry. I don't think they exist in any other language, but we need to double-check to ensure they aren't simply listed under a different name. Add the missing .NET modules to the Community Module Registry:

  • ActiveMq
  • BigQuery
  • Bigtable
  • FirebirdSql
  • Firestore
  • JanusGraph
  • Kusto
  • Papercut
  • PubSub
  • ServiceBus
  • Sftp
  • Xunit

Solution

Create a PR in the upstream repository that adds one of the listed missing modules.

Benefit

-

Alternatives

-

Would you like to help contributing this enhancement?

Yes

@HofmeisterAn HofmeisterAn added chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups enhancement New feature or request help wanted Extra attention is needed labels Feb 15, 2025
@HofmeisterAn HofmeisterAn pinned this issue Feb 15, 2025
@fabbrik
Copy link

fabbrik commented Mar 4, 2025

I would like to help with this. I do not want to overstep, please let me know whiff u still need help.

@HofmeisterAn
Copy link
Collaborator Author

No, I don't believe anyone is currently working on this issue. It would make sense for someone who wants to add a missing module to leave a comment here, mentioning which module they intend to add.

@digital88
Copy link
Contributor

@HofmeisterAn
Hi.
testcontainers/community-module-registry#129
New modules are without images.

There is a small problem with google-cloud modules. All other langs provide a single package for all this: BigQuery, Bigtable, Firestore, PubSub. Maybe it's good idea to also consolidate them to single package.

Also not sure how to add xUnit there. Skipped it for now.

@HofmeisterAn
Copy link
Collaborator Author

There is a small problem with google-cloud modules. All other langs provide a single package for all this: BigQuery, Bigtable, Firestore, PubSub. Maybe it's good idea to also consolidate them to single package.

Thanks for taking care of this. Good observation. Maybe it makes sense to skip these modules until we have a single package. We likely can create a wrapper NuGet that includes all of them.

@digital88
Copy link
Contributor

Maybe it makes sense to skip these modules

Removed all gcloud modules.

Also activemq dotnet module already exists in artemis folder.

List of added modules from first post currently is:

  • FirebirdSql
  • JanusGraph
  • Kusto
  • Papercut
  • Sftp

@digital88
Copy link
Contributor

digital88 commented Mar 23, 2025

Those 5 modules were added.

@digital88
Copy link
Contributor

About adding xunit see here: testcontainers/community-module-registry#132

@digital88
Copy link
Contributor

  • ActiveMq

Already added here https://github.com/testcontainers/community-module-registry/blob/main/modules/artemis/index.md?plain=1

@HofmeisterAn
Copy link
Collaborator Author

Thanks for your contributions. The only remaining modules are the Google ones. So, we just need a wrapper project that collects all of them.

TBH I'm not sure if that's ideal for visibility, etc. e.g. we're not doing it for Azure either. But let's keep it consistent with the other languages. It shouldn't be too much work.

@digital88
Copy link
Contributor

Thanks for your contributions. The only remaining modules are the Google ones. So, we just need a wrapper project that collects all of them.

TBH I'm not sure if that's ideal for visibility, etc. e.g. we're not doing it for Azure either. But let's keep it consistent with the other languages. It shouldn't be too much work.

Please see #1411

@digital88
Copy link
Contributor

  • Xunit

This was merged testcontainers/community-module-registry#132

@digital88
Copy link
Contributor

GCloud module as draft PR testcontainers/community-module-registry#134

Should publish 4.4.0 to Nuget first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants