Skip to content

Skip to main content link is missing #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbranchini opened this issue Oct 8, 2024 · 4 comments · Fixed by #1440 or #1447
Closed

Skip to main content link is missing #1431

dbranchini opened this issue Oct 8, 2024 · 4 comments · Fixed by #1440 or #1447

Comments

@dbranchini
Copy link

dbranchini commented Oct 8, 2024

SiteImprove flags this as "Skip to main content is missing." It's not missing, but it's not first. "Skip to search" is first instead. See screenshot.

Screenshot 2024-10-08 at 4 31 45 PM

Guidance
https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html.

Given the guidance linked above (which suggests it should be first), I recommend that we reverse the order "Skip to main content" and then "Skip to search."

thatbudakguy added a commit to projectblacklight/blacklight that referenced this issue Oct 9, 2024
Some accessibility checkers, like SiteImprove, regard it as a
failure that the 'skip to main' link is not the first focusable
element on the page.

This swaps the order of the 'skip to main' and 'skip to search'
links so that 'skip to main' comes first, which is in line with
the WCAG 2.2 guidelines
(https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html).

Related: sul-dlss/earthworks#1431
@jcoyne
Copy link
Contributor

jcoyne commented Oct 11, 2024

isn't the search the first element in the main content? Won't skipping to main require extra keystrokes?

@dbranchini
Copy link
Author

It looks like there's an added link now, "Skip to first result," so the order should be "Skip to main content" (required), "Skip to first result," and then "Skip to search." We discussed this with SODA and at a DLUX team meeting. Here's the reasoning:

  • We also want the tabbing order to be fixed - see Focus order on search results page #1259 (also discussed with SODA). Once that's fixed, then skip to main content goes to and the first thing they'll encounter are facets.
  • Skip to search is last because once you do a search (from home or the search page), you end up at the top of the page again, most likely want to explore the content before doing another search.

@dbranchini
Copy link
Author

dbranchini commented Oct 16, 2024

Also, note the <main> element is sufficient and preferred to the role and aria-label attributes - see screenshot.

Screenshot 2024-10-16 at 4 41 45 PM

cbeer pushed a commit to projectblacklight/blacklight that referenced this issue Oct 23, 2024
Some accessibility checkers, like SiteImprove, regard it as a
failure that the 'skip to main' link is not the first focusable
element on the page.

This swaps the order of the 'skip to main' and 'skip to search'
links so that 'skip to main' comes first, which is in line with
the WCAG 2.2 guidelines
(https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html).

Related: sul-dlss/earthworks#1431
cbeer pushed a commit to projectblacklight/blacklight that referenced this issue Oct 23, 2024
Some accessibility checkers, like SiteImprove, regard it as a
failure that the 'skip to main' link is not the first focusable
element on the page.

This swaps the order of the 'skip to main' and 'skip to search'
links so that 'skip to main' comes first, which is in line with
the WCAG 2.2 guidelines
(https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html).

Related: sul-dlss/earthworks#1431
@corylown
Copy link
Contributor

This will be fixed by updating Blacklight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants