Swap order of skip links so main content comes first #3354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some accessibility checkers, like SiteImprove, regard it as a failure that the 'skip to main' link is not the first focusable element on the page. This swaps the order of the 'skip to main' and 'skip to search' links so that 'skip to main' comes first, which is in line with the WCAG 2.2 guidelines (https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html). Related: sul-dlss/earthworks#1431
|
While this may satisfy automated accessibility checkers, I suspect the first interaction people will use in a Blacklight site is the "Search". So I wonder if this would cause a regression in usability for keyboard users. |
|
This makes sense to me. If we want to make it easier to get to search, that seems like a good opportunity for keyboard shortcuts using javascript + https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some accessibility checkers, like SiteImprove, regard it as a
failure that the 'skip to main' link is not the first focusable
element on the page.
This swaps the order of the 'skip to main' and 'skip to search'
links so that 'skip to main' comes first, which is in line with
the WCAG 2.2 guidelines
(https://www.w3.org/WAI/WCAG22/Techniques/general/G1.html).
Related: sul-dlss/earthworks#1431