Skip to content

Separate dockerfile for goreleaser #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Jun 30, 2023

Turns out #430 isn't compatible with goreleaser, which seems obvious in retrospect. I found goreleaser docs that suggest

If you still want your users to be able to docker build without an extra step, you can have a Dockerfile just for GoReleaser, for example, a goreleaser.dockefile.

so, this PR is that.

@richardm-stripe richardm-stripe requested review from a team and anniel-stripe and removed request for a team June 30, 2023 01:50
Co-authored-by: anniel-stripe <[email protected]>
@richardm-stripe richardm-stripe enabled auto-merge (squash) June 30, 2023 03:02
@richardm-stripe richardm-stripe merged commit 4b5e202 into master Jun 30, 2023
@richardm-stripe richardm-stripe deleted the richardm-separate-goreleaser-dockerfile branch June 30, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants