-
Notifications
You must be signed in to change notification settings - Fork 117
fix(Docker): Macos docker failure #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Docker): Macos docker failure #430
Conversation
Native binary loaded into docker images doesn't work in case of Mac. Hence changed docker to build and create the docker image.
order_id/txn_id/txn_uuid are mandatory in metadata for hyperswitch. this change allows hyperswitch to test payment_intent but cards aren't supported by stripe mock. So instead use `sepa bank debit` `{ "amount": 6540, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "StripeCustomer", "email": "[email protected]", "name": "John Doe", "phone": "999999999", "phone_country_code": "+1", "description": "Its my first payment request", "authentication_type": "no_three_ds", "return_url": "https://google.com", "payment_method": "card", "payment_method_type": "credit", "payment_method_data": { "bank_debit": { "sepa_bank_debit": { "iban": "1234", "bank_account_holder_name": "John", "billing_details": { "name" : "John Doe", "email": "[email protected]" } } } }, "billing": { "address": { "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "city": "San Fransico", "state": "California", "zip": "94122", "country": "US", "first_name": "joseph", "last_name": "Doe" }, "phone": { "number": "8056594427", "country_code": "+91" } }, "shipping": { "address": { "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "city": "San Fransico", "state": "California", "zip": "94122", "country": "US", "first_name": "joseph", "last_name": "Doe" }, "phone": { "number": "8056594427", "country_code": "+91" } }, "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "metadata": { "udf1": "value1", "new_customer": "true", "login_date": "2019-09-10T10:11:12Z", "order_id": "123" } }`
Hello @ashokkjag, thank you for the contribution. Can you explain/provide more details about the failure you saw (and how to trigger it) that this change is fixing? Presumably in our |
Hi Richard,
Issue isn't with the image on dockerhub. Issue is when I try to modify some
fixtures.json and try to locally build and run that image.
Since the local `make build`/`make docker-build` only builds a MacOS
binary, this gets packaged into docker. Hence the change to build and
package inside docker.
Thanks for looking into this Issue/PR and keep up the good work.
…-Ashok
On Mon, Jun 26, 2023 at 11:24 PM Richard Marmorstein < ***@***.***> wrote:
Hello @ashokkjag <https://github.com/ashokkjag>, thank you for the
contribution.
Can you explain/provide more details about the failure you saw (and how to
trigger it) that this change is fixing? Presumably in our .goreleaser.yml
we are building for both AMD64 and ARM64
https://github.com/stripe/stripe-mock/blob/master/goreleaser.yml#L61-L77,
and on my Mac, docker run --rm -it -p 12111-12112:12111-12112
stripe/stripe-mock:latest succeeds. I'd like to be able to trigger the
failure myself before I merge a fix.
—
Reply to this email directly, view it on GitHub
<#430 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOLKDHERYP4EAY34OKJAI3XNHEDXANCNFSM6AAAAAAZONNEHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
.- ... .... --- -.-
|
Ahh I get it. Your shell prompt threw me for a loop but I understand it now! You could get the "copy locally-built binary over" approach to work like $ GOOS=linux GOARCH=amd64 make build && make docker-build && make docker-run but I think I prefer your build-in-docker approach better. Could you remove the |
Sorry Richard, Didn't realize I was commiting my test changes to the PR branch. Reverted the fixtures change. |
Thank you for the contribution @ashokkjag! |
Native binary loaded into docker images doesn't work in case of Mac. Hence changed docker to build and create the docker image.