Skip to content

Fix Windows build fails due to incorrect dep references #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sgrebnov
Copy link
Contributor

@sgrebnov sgrebnov commented Jun 9, 2016

This fixes #32.

@brody4hire
Copy link
Collaborator

Thanks! Will be included within the next hour or so.

@brody4hire
Copy link
Collaborator

Thanks! I will include this within the next hour or so.

@sgrebnov
Copy link
Contributor Author

sgrebnov commented Jun 9, 2016

Thank you 👍
I see there is Travis build failure, as per log this seems to be unrelated, is it something expected?

@brody4hire
Copy link
Collaborator

Your change is now incorporated in the default branch. I cherry-picked it since there was another change that I forgot to push before. Please test the default branch and confirm that it is working for you on Windows.

You can ignore the Travis build failure. Unfortunately Travis CI seems to be a bit flakey, especially at certain times of the day. I think Travis CI works best before noon CET.

@brody4hire
Copy link
Collaborator

And it even passed Travis CI after I cherry-picked your fix!

@brody4hire brody4hire closed this Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants