Windows build fails due to incorrect dep references

[sgrebnov]

λ cordova --version
6.2.0
λ cordova platforms
  windows 4.3.2

C:\temp\sqlCipher
λ cordova build windows --archs=x86
Building project: C:\temp\sqlCipher\platforms\windows\CordovaApp.Windows.jsproj
        Configuration : debug
        Platform      : x86
  pch.cpp
  Constants.cpp
  Database.cpp
  Statement.cpp
c:\temp\sqlcipher\plugins\cordova-sqlcipher-adapter\src\windows\sqlite3-win-rt\sqlite3\database.cpp(57): warning C4244: 'return' : conversion from 'sqlite3_int64' to 'int', possible loss of data [C:\temp\sqlCip her\plugins\cordova-sqlcipher-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
  sqlite3.c
  cbc_encrypt.c
  cbc_decrypt.c
  cbc_start.c
  cbc_done.c
  crypt_find_cipher.c
  crypt_find_hash.c
  crypt_register_hash.c
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\common\sqlite3.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapt er\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\crypt_find_hash.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sq lcipher-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\crypt_find_cipher.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova- sqlcipher-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\crypt_register_hash.c': No such file or directory [C:\temp\sqlCipher\plugins\cordov a-sqlcipher-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\cbc_encrypt.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sqlcip her-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\cbc_done.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sqlcipher -adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\cbc_start.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sqlciphe r-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\libTomCrypt\cbc_decrypt.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sqlcip her-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]
...
Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed with exit code 1

libTomCrypt is stored in src\windows\ but the plugin expects it to be in src\external\ folder.

[sgrebnov]

Same with common\sqlite3.c:

c1 : fatal error C1083: Cannot open source file: 'C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\external\common\sqlite3.c': No such file or directory [C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapt er\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.Windows\SQLite3.Windows.vcxproj]

[sgrebnov]

Looks like this was broken by the following change: Merge branch 'cipher-common-src' into cipher-ext-master, c996de7

[brody4hire]

Looks like this was broken by the following change: Merge branch 'cipher-common-src' into cipher-ext-master, c996de7

Yes.

[brody4hire]

I think we can just back out most but not all of the changes to src/windows/SQLite3-Win-RT/SQLite3/SQLite3.Shared.vcxitems in c996de7. The changes to the compile flags should stay.

[sgrebnov]

Sorry for delayed response, looks like the following change breaks the build on windows.

af3d1ed

c:\temp\sqlcipher\plugins\cordova-sqlcipher-adapter\src\common\sqlite3.c(17959): error C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_S ECURE_NO_WARNINGS. See online help for details. [C:\temp\sqlCipher\plugins\cordova-sqlcipher-adapter\src\windows\SQLite3-Win-RT\SQLite3\SQLite3.UWP\SQLite3.UWP.vcxproj]

Reported as #34