Skip to content

SDP 1645 fetch direct payments #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: SDP-1644-create-direct-payment
Choose a base branch
from
Open

SDP 1645 fetch direct payments #694

wants to merge 6 commits into from

Conversation

dpohr
Copy link
Collaborator

@dpohr dpohr commented May 30, 2025

What

Add type query parameter to GET /payments endpoint for filtering by payment type. Supports type=direct for one-off payments and type=disbursement for batch payments.

Why

Add ability distinguish between direct payments and disbursement payments

Known limitations

Built on top of the #693

Checklist

  • Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
  • PR has a focused scope and doesn't mix features with refactoring
  • Tests are included (if applicable)
  • CHANGELOG.md is updated (if applicable)
  • CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
  • Preview deployment works as expected
  • Ready for production

@dpohr dpohr self-assigned this May 30, 2025
@dpohr dpohr temporarily deployed to Anchor Integration Tests May 30, 2025 11:16 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 30, 2025 11:16 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr694.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr694.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr694.previews.kube001.services.stellar-ops.com

@dpohr dpohr requested a review from marwen-abid June 2, 2025 09:17
@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 6, 2025 15:53 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 6, 2025 15:53 — with GitHub Actions Inactive
@dpohr dpohr marked this pull request as ready for review June 6, 2025 15:56
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr694.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr694.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr694.previews.kube001.services.stellar-ops.com

@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 07:07 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 07:07 — with GitHub Actions Inactive
@dpohr dpohr changed the base branch from develop to SDP-1644-create-direct-payment June 12, 2025 07:09
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr694.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr694.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr694.previews.kube001.services.stellar-ops.com

@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 07:21 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 07:21 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr694.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr694.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr694.previews.kube001.services.stellar-ops.com

@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 07:25 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 07:25 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr694.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr694.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr694.previews.kube001.services.stellar-ops.com

@dpohr dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 07:37 — with GitHub Actions Inactive
@dpohr dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 07:37 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr694.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr694.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr694.previews.kube001.services.stellar-ops.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwen-abid marwen-abid Awaiting requested review from marwen-abid

Assignees

@dpohr dpohr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpohr @stellar-jenkins