SDP 1644 create direct payment #693

dpohr · 2025-05-30T06:51:36Z

What

Implements POST /payments API endpoint for direct payments to existing receivers without creating disbursements. Adds new "DIRECT" payment type with flexible entity reference system (by ID, email, phone, wallet address) and integrates with existing payment processing pipeline.

Why

Enables on-demand, single payments for API integrations that don't fit the batch disbursement workflow. Critical for use cases like instant payments, manual corrections, and external system integrations that need immediate payment capability without disbursement overhead.

Known limitations

Existing receivers only - does not create new receivers (by design for this iteration)
Contract/Fiat assets - marked as future implementation, returns proper "not supported" errors
Legacy auth - still uses token extraction method (TODO: migrate to API keys when available)

Checklist

Title follows SDP-1234: Add new feature or Chore: Refactor package xyz format. The Jira ticket code was included if available.
PR has a focused scope and doesn't mix features with refactoring
Tests are included (if applicable)
CHANGELOG.md is updated (if applicable)
CONFIG/SECRETS changes are updated in helmcharts and deployments (if applicable)
Preview deployment works as expected
Ready for production

…rect-payment

stellar-jenkins · 2025-05-30T06:55:58Z

Something went wrong with PR preview build please check

stellar-jenkins · 2025-05-30T06:55:58Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-30T07:26:15Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-05-30T07:55:19Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-06-02T13:05:21Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-06-12T07:08:16Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

socket-security · 2025-06-12T09:31:15Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	golang/github.com/stellar/go@v0.0.0-20250311234916-385ac5aca1a4 ⏵ v0.0.0-20250606230746-ef10cd0a5920	^-1

View full report

stellar-jenkins · 2025-06-12T09:34:04Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-06-12T11:04:46Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-06-12T11:11:16Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

marwen-abid

🚨 When I try to trigger a Direct Payment, I get the following error

time="2025-06-12T20:52:00.315-07:00" level=error msg="Payment e66f5d1a-cd8c-4a3f-a1db-ab3678c130fd is not ready for sending. Error=disbursement  for payment e66f5d1a-cd8c-4a3f-a1db-ab3678c130fd is not in STARTED state" pid=51849

The issue comes from payment_to_submitter_service.go L 178

if p.PaymentType == data.PaymentTypeDisbursement || p.Disbursement != nil {

p.Disbursement here is not nil, there is an empty disbursement object.

marwen-abid · 2025-06-13T03:36:51Z

internal/serve/serve.go

+			r.With(middleware.RequirePermission(
+				data.WritePayments,
+				middleware.AnyRoleMiddleware(authManager, data.OwnerUserRole, data.FinancialControllerUserRole, data.BusinessUserRole),
+			)).Patch("/retry", paymentsHandler.RetryPayments)


🚨 r.Post("/", paymentsHandler.PostPayment) is missing here.

🧪 Can you also add a test to Test_handleHTTP_authenticatedEndpoints for POST /payments

stellar-jenkins · 2025-06-13T16:29:52Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2025-06-13T17:33:42Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr693.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr693.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr693.previews.kube001.services.stellar-ops.com

dpohr added 7 commits May 23, 2025 20:03

SDP-1644 create direct payment

bdda140

SDP-1644

55fa6c7

Merge remote-tracking branch 'origin/develop' into SDP-1644-create-di…

13ba133

…rect-payment

SDP-1644

a97ca78

SDP-1644 fix existing tests

23bac55

SDP-1644 add tests

a23b280

SDP-1644 add direct payment tests and additional error types

df5827e

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 30, 2025 06:51 — with GitHub Actions Inactive

dpohr temporarily deployed to Anchor Integration Tests May 30, 2025 06:51 — with GitHub Actions Inactive

github-actions bot assigned dpohr May 30, 2025

Merge branch 'develop' into SDP-1644-create-direct-payment

60280a5

dpohr temporarily deployed to Anchor Integration Tests May 30, 2025 06:51 — with GitHub Actions Inactive

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 30, 2025 06:51 — with GitHub Actions Inactive

SDP-1644

646cdd0

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 30, 2025 07:23 — with GitHub Actions Inactive

dpohr temporarily deployed to Anchor Integration Tests May 30, 2025 07:23 — with GitHub Actions Inactive

SDP-1644 update changelog

1b9885c

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) May 30, 2025 07:52 — with GitHub Actions Inactive

dpohr temporarily deployed to Anchor Integration Tests May 30, 2025 07:52 — with GitHub Actions Inactive

dpohr mentioned this pull request May 30, 2025

SDP 1645 fetch direct payments #694

Open

7 tasks

dpohr requested a review from marwen-abid June 2, 2025 09:17

SDP-1644 change service init

fc7b386

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 2, 2025 13:02 — with GitHub Actions Inactive

dpohr temporarily deployed to Anchor Integration Tests June 2, 2025 13:02 — with GitHub Actions Inactive

marwen-abid requested a review from marcelosalloum June 3, 2025 18:01

SDP-1644 ready payments query adjustment

ea24ee8

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 07:05 — with GitHub Actions Inactive

dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 07:05 — with GitHub Actions Inactive

dpohr added 2 commits June 12, 2025 11:05

SDP-1644 go mod update, test discussion fix

64031d1

SDP-1644 contract value validation

c907fb2

dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 09:30 — with GitHub Actions Inactive

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 09:30 — with GitHub Actions Inactive

SDP-1644

f6c1e55

dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 11:02 — with GitHub Actions Inactive

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 11:02 — with GitHub Actions Inactive

SDP-1644 update go list

ecbbc6d

dpohr temporarily deployed to Anchor Integration Tests June 12, 2025 11:08 — with GitHub Actions Inactive

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 12, 2025 11:08 — with GitHub Actions Inactive

dpohr requested review from philipliu and marwen-abid June 12, 2025 11:22

marwen-abid reviewed Jun 13, 2025

View reviewed changes

dpohr added 2 commits June 13, 2025 10:49

SDP-1644

1e96385

SDP-1644 change payment type handling

d563ee3

dpohr temporarily deployed to Anchor Integration Tests June 13, 2025 16:27 — with GitHub Actions Inactive

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 13, 2025 16:27 — with GitHub Actions Inactive

SDP-1644 additional nil handling for the direct payment

8c9160c

dpohr temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) June 13, 2025 17:30 — with GitHub Actions Inactive

dpohr temporarily deployed to Anchor Integration Tests June 13, 2025 17:30 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SDP 1644 create direct payment #693

SDP 1644 create direct payment #693

Uh oh!

dpohr commented May 30, 2025 •

edited

Loading

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented Jun 2, 2025

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

socket-security bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

marwen-abid left a comment

Uh oh!

marwen-abid Jun 13, 2025

Uh oh!

marwen-abid Jun 13, 2025

Uh oh!

stellar-jenkins commented Jun 13, 2025

Uh oh!

stellar-jenkins commented Jun 13, 2025

Uh oh!

Uh oh!

SDP 1644 create direct payment #693

Are you sure you want to change the base?

SDP 1644 create direct payment #693

Uh oh!

Conversation

dpohr commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Checklist

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented May 30, 2025

Uh oh!

stellar-jenkins commented Jun 2, 2025

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

socket-security bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

stellar-jenkins commented Jun 12, 2025

Uh oh!

marwen-abid left a comment

Choose a reason for hiding this comment

Uh oh!

marwen-abid Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

marwen-abid Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Jun 13, 2025

Uh oh!

stellar-jenkins commented Jun 13, 2025

Uh oh!

Uh oh!

dpohr commented May 30, 2025 •

edited

Loading

socket-security bot commented Jun 12, 2025 •

edited

Loading