all: remove dep source for govalidator #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `source` parameter for the github.com/asaskevich/govalidator dependency. The source parameter is pointing to the same repository, just with a `.git` extension. GitHub treats the two repository URLs the same. The presence of the source parameter causes `go mod init` to think the `source` is pointing to a fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbotThoroughness
This PR adds tests for the most critical parts of the new functionality or fixes.I've updated any docs (developer docs,.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
I've updated the relevant CHANGELOG (here for Horizon) ifneeded with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
Remove the
sourceparameter for theg.yxqyang.asia/asaskevich/govalidatordependency in the dep Gopkg.* files.Goal and scope
This change is being made to simplify the
go.modfile that will be generated when we move to Modules (#1634).The
sourceparameter for theg.yxqyang.asia/asaskevich/govalidatordependency is pointing to the same repository as the dependency name, just with a.gitextension. GitHub treats the two repository URLs the same and it was probably an error that we set the source to that value. The presence of thesourceparameter causesgo mod initwhen converting from go dep to go modules to think thesourceis pointing to a fork which adds an extra unnecessaryreplacedirective to the thego.modfile that is generated.This change is expected to be a no-op on existing functionality and on the dependencies that get pulled in during a build as it should cause no changes to the dependencies that
deppulls in.Summary of changes
sourceparameter with abranchparameter. The branch parameter is required because either asource,revision, orbranchparameter must be provided.Known limitations & issues
N/A
What shouldn't be reviewed
N/A