Skip to content

Commit f65ea5f

Browse files
all: remove dep source for govalidator (#1638)
Remove the `source` parameter for the `github.com/asaskevich/govalidator` dependency in the dep Gopkg.* files. This change is being made to simplify the `go.mod` file that will be generated when we move to Modules (#1634). The `source` parameter for the `github.com/asaskevich/govalidator` dependency is pointing to the same repository as the dependency name, just with a `.git` extension. GitHub treats the two repository URLs the same and it was probably an error that we set the source to that value. The presence of the `source` parameter causes `go mod init` when converting from go dep to go modules to think the `source` is pointing to a fork which adds an extra unnecessary `replace` directive to the the `go.mod` file that is generated. This change is expected to be a no-op on existing functionality and on the dependencies that get pulled in during a build as it should cause no changes to the dependencies that `dep` pulls in.
1 parent 472f6d0 commit f65ea5f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Gopkg.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
name = "bitbucket.org/ww/goautoneg"
44

55
[[constraint]]
6+
branch = "master"
67
name = "github.com/asaskevich/govalidator"
7-
source = "https://github.com/asaskevich/govalidator.git"
88

99
[[constraint]]
1010
name = "github.com/go-chi/chi"

0 commit comments

Comments
 (0)