Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: escape spaces in call to make #662

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

WardBrian
Copy link
Member

Not sure if this works on Windows

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #659

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Not sure if this works on Windows
@WardBrian WardBrian added bug Something isn't working build download, install, and devops issues labels Mar 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #662 (0a3293c) into develop (087a765) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #662   +/-   ##
========================================
  Coverage    80.56%   80.56%           
========================================
  Files           69       69           
  Lines        10653    10653           
========================================
  Hits          8583     8583           
  Misses        2070     2070           

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian WardBrian marked this pull request as ready for review March 24, 2023 17:27
@WardBrian
Copy link
Member Author

Huh, seems like that did work on Windows. Ready for review, then

@WardBrian WardBrian merged commit 10c2b46 into develop Mar 24, 2023
@WardBrian WardBrian deleted the fix/659-space-include-paths branch March 24, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build download, install, and devops issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic include-path specification interacts poorly with spaces in filepaths
3 participants