Skip to content

Planning the next CmdStanPy release #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WardBrian opened this issue Sep 5, 2023 · 0 comments · Fixed by #691
Closed

Planning the next CmdStanPy release #690

WardBrian opened this issue Sep 5, 2023 · 0 comments · Fixed by #691
Assignees
Labels
question Further information is requested

Comments

@WardBrian
Copy link
Member

I think we should try to have a new cmdstanpy release in the next couple weeks. Depending on some choices we make this will either be 1.2.0 or 2.0.0 (discussion below).

Changes so far:

New Features:

Fixes and Minor Changes:


The only reasons this would need to be 2.0 are in #681. The return type of CmdStanMLE.stan_variable changed from sometimes-float-sometimes-ndarray to always ndarray, and the meaning of CmdStanVB.stan_variable changed from returning the mean approximation to the draws from the variational approximation (see #636).

We could patch around/partially revert these two changes and instead emit warnings, release as 1.2.0, and then plan a 2.0 which would make the changes and remove anything else marked as deprecated. Or, we could just release what is currently merged as 2.0.

In either case, it is also worth doing a once-over on the API and seeing if anything else should be deprecated and removed. There was some discussion in #689 of the after-construction compilation being an odd feature of the model class, and discussion in #684 of various arguments with different names that all mean draws.

@WardBrian WardBrian added the question Further information is requested label Sep 5, 2023
@WardBrian WardBrian mentioned this issue Sep 6, 2023
2 tasks
@WardBrian WardBrian linked a pull request Sep 21, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants