-
Notifications
You must be signed in to change notification settings - Fork 206
feat(server/fileuploads): use a presigned url to upload large files #4901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(server/fileuploads): use a presigned url to upload large files #4901
Conversation
@@ -41,12 +41,9 @@ import { | |||
import { | |||
getBranchByIdFactory, | |||
markCommitBranchUpdatedFactory, | |||
getStreamBranchByNameFactory, | |||
createBranchFactory | |||
getStreamBranchByNameFactory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the createStream
and all the boilerplate in to a helper function so it can be shared amongst tests. Otherwise, no changes to this file.
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (73.27%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4901 +/- ##
==========================================
- Coverage 70.54% 69.64% -0.90%
==========================================
Files 587 602 +15
Lines 25300 25888 +588
Branches 3777 3816 +39
==========================================
+ Hits 17847 18029 +182
- Misses 6273 6700 +427
+ Partials 1180 1159 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Review comments
|
Description & motivation
The client can request a pre-signed URL via the GraphQL API.
Once the client has uploaded a file using the presigned url, this PR allows the client to register the completion of the upload via GraphQL API.
Changes:
graphql mutations for:
generateUploadUrl
startFileImport
environment variables:
FF_LARGE_FILE_IMPORTS_ENABLED
FILE_UPLOAD_URL_EXPIRY_MINUTES
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References