Skip to content

WIP: feat(blobstorage): expire stale pending uploads #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jun 6, 2025

Description & motivation

Changes:

To-do before merge:

  • should it check whether an object is present in the S3-compatible storage?

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 59.18367% with 40 lines in your changes missing coverage. Please review.

Project coverage is 59.07%. Comparing base (2fcd0e6) to head (df40192).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
packages/shared/src/blobs/fileTypes.ts 0.00% 31 Missing and 1 partial ⚠️
packages/shared/src/authz/policies/index.ts 25.00% 6 Missing ⚠️
packages/shared/src/blobs/index.ts 0.00% 0 Missing and 1 partial ⚠️
packages/shared/src/index.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2fcd0e6) and HEAD (df40192). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (2fcd0e6) HEAD (df40192)
8 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4900       +/-   ##
===========================================
- Coverage   70.54%   59.07%   -11.48%     
===========================================
  Files         588      114      -474     
  Lines       25277     4100    -21177     
  Branches     3774      511     -3263     
===========================================
- Hits        17832     2422    -15410     
+ Misses       6265     1649     -4616     
+ Partials     1180       29     -1151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant