-
Notifications
You must be signed in to change notification settings - Fork 711
[201911] show ip int changes #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
This pull request introduces 5 alerts and fixes 2 when merging d0b2e1a into 603ac53 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments.
Also please fix LGTM alerts
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
This pull request introduces 5 alerts and fixes 2 when merging 3ca75ea into e54fb69 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM alerts still present
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
This pull request fixes 2 alerts when merging 0f9bb75 into e54fb69 - view on LGTM.com fixed alerts:
|
Fixed them in latest commit |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]> Install pyroute2 for sonic-utilities. This change is needed for sonic-net/sonic-utilities#1437
This PR is port of #6845 for 201911 show ip interfaces is enhanced recently to support multi ASIC platforms in this sonic-net/sonic-utilities#1437. The ipintutil script as to run as sudo user, to get the ip interface from each namespace. Add this script to the sudoer file so that show ip interface command is available for user with read-only permissions Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
retest this please |
2 similar comments
retest this please |
retest this please |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
This pull request fixes 2 alerts when merging c22bd54 into ce82ff6 - view on LGTM.com fixed alerts:
|
[201911] show ip int changes (sonic-net#1437) Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
- What I did
The PR has changes to support command
show ip interface
for multi asic platform.Dependent on this PR: sonic-net/sonic-buildimage#6792
- How I did it
The following changes are done in this PR
The code for
show ip interface
has been moved fromshow/main.py
toscripts\ipintutil
Modify the code to support both single and multi asic platform
Add the following options for multi asic
[-n, --namespace] to allow user to display the information for given namespaces
If this option is not present the information from all the namespaces will be displayed
[-d, --display] to allow user to display information related both internal and external interfaces
If this option is not present only external interfaces/neighbors will be display
Add unit tests for single and multi asic
- How to verify it
Verify on single and multi asic