[201911] Install pyroute2 for sonic-utilities #6792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
jleveque
suggested changes
Feb 16, 2021
Comment on lines
+154
to
+155
| #Install pyroute2==0.5.14 via pip in order to support get ip interface from kernal for sonic-utilities | ||
| sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip install pyroute2==0.5.14 |
There was a problem hiding this comment.
Prefer to add this dependency to the setup.py file in the sonic-utilities repo rather than installing explicitly here.
Nevermind. I just realized this PR is against the 201911 branch, where the sonic-utilities package is still built as a .deb package. This is OK.
There was a problem hiding this comment.
@jleveque, Yes this is for 201911. Sorry I missed 201911 in the title
jleveque
changed the title
jleveque
approved these changes
Feb 16, 2021
|
retest this please |
1 similar comment
|
retest this please |
arlakshm
added a commit
to Azure/sonic-build-tools
that referenced
this pull request
Feb 24, 2021
pyroute2 was added to image in this PR sonic-net/sonic-buildimage#6792 Install pyroute2 in the sonic-utilities PR build script. Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
Why I did it
Install pyroute2 for sonic-utilities. This change is needed for sonic-net/sonic-utilities#1437
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)