Skip to content

[connect][clear] Support --devicename option for connect/clear line commands #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Nov 4, 2020

- What I did
Support --devicename and -d option for sonic-clear/connect line commands

- How I did it
Add missing options.

- How to verify it
Tested on physical SONiC DUT with below initial configuration.

admin@sonic:~$ sudo show line -b
  Line    Baud    PID    Start Time    Device
------  ------  -----  ------------  --------
     1    9600      -             -   switch1

- Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo connect line --devicename switch1
Usage: connect line [OPTIONS] LINENUM
Try "connect line -h" for help.

Error: no such option: --devicename
admin@sonic:~$ sonic-clear line --devicename switch1
Usage: sonic-clear line [OPTIONS] LINENUM
Try "sonic-clear line -h" for help.

Error: no such option: --devicename

- New command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo connect line --devicename switch1
Successful connection to line 1
Press ^A ^X to disconnect


admin@sonic:~$ sudo sonic-clear line --devicename switch1
admin@sonic:~$ sudo show line -b
  Line    Baud    PID    Start Time    Device
------  ------  -----  ------------  --------
     1    9600      -             -   switch1

@Blueve Blueve requested a review from yxieca November 4, 2020 07:29
@Blueve Blueve changed the title [connect][clear] Support --devicename option for connect/clear line ommands [connect][clear] Support --devicename option for connect/clear line commands Nov 4, 2020
@lguohan
Copy link
Contributor

lguohan commented Nov 4, 2020

i think we need to add the doc for this command line change.

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the new --devicename option for both clear and connect in the CommandReference document.

@Blueve Blueve requested a review from jleveque November 5, 2020 04:06
@Blueve
Copy link
Contributor Author

Blueve commented Nov 5, 2020

@lguohan @jleveque I updated the documents, I found that there are no clear/connect commands documents although we have those commands.

  • Add document for show line and move it to console section
  • Add document for config console ...
  • Add document for connect/clear line

@lguohan lguohan merged commit 927bf9b into sonic-net:master Nov 5, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Multi-Db changes for NAT feature. (sonic-net#1202)
[cfgmgr] clear loopback and vrf in kernel if not warmstart (sonic-net#1141)
 upon cold reboot, skip remove mgmt vrf table from the kernel (sonic-net#1214)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
    Multi-Db changes for NAT feature. (sonic-net#1202)
    [cfgmgr] clear loopback and vrf in kernel if not warmstart (sonic-net#1141)
     upon cold reboot, skip remove mgmt vrf table from the kernel (sonic-net#1214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants