Skip to content

Show sflow interface to display all interfaces enabled for sflow #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tonytitus
Copy link
Contributor

@tonytitus tonytitus commented Sep 29, 2020

- What I did
"show sflow interface" is updated to show all interfaces enabled for sflow

- How I did it
Updated sflow show command

- How to verify it
Run "show sflow interface" and confirm all interfaces are displayed

- Previous command output (if the output of a command-line utility has changed)

show sflow interface

sFlow interface configurations
+-------------+---------------+-----------------+
| Interface | Admin State | Sampling Rate |
+=============+===============+=================+
| Ethernet4 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet12 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet16 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet26 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet34 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet42 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet52 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet58 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet68 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet78 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet84 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet88 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet98 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet110 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet112 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet120 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet132 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet142 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet150 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet158 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet164 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet174 | up | 10000 |
+-------------+---------------+-----------------+

- New command output (if the output of a command-line utility has changed)

show sflow interface

sFlow interface configurations
+-------------+---------------+-----------------+
| Interface | Admin State | Sampling Rate |
+=============+===============+=================+
| Ethernet0 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet2 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet4 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet6 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet8 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet10 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet12 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet14 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet16 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet18 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet20 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet22 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet24 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet26 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet28 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet30 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet32 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet34 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet36 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet38 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet40 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet42 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet44 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet46 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet48 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet50 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet52 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet54 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet56 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet58 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet60 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet62 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet64 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet66 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet68 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet70 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet72 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet74 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet76 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet78 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet80 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet82 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet84 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet86 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet88 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet90 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet92 | up | 10000 |
+-------------+---------------+-----------------+
...
...
+-------------+---------------+-----------------+
| Ethernet224 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet226 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet228 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet230 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet232 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet234 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet236 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet238 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet240 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet242 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet244 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet246 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet248 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet250 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet252 | up | 10000 |
+-------------+---------------+-----------------+
| Ethernet254 | up | 10000 |
+-------------+---------------+-----------------+

@GarrickHe
Copy link
Contributor

@tonytitus - Can you show the output when you run show sflow interface pre/post change? Thank you.

@tonytitus
Copy link
Contributor Author

@tonytitus - Can you show the output when you run show sflow interface pre/post change? Thank you.

Added

Copy link
Contributor

@GarrickHe GarrickHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prsunny
Copy link
Contributor

prsunny commented Sep 30, 2020

Can you raise this PR to master?

@tonytitus
Copy link
Contributor Author

Can you raise this PR to master?

Raised #1143 for master

Any idea why build is failing?

@tonytitus
Copy link
Contributor Author

retest default

@prsunny
Copy link
Contributor

prsunny commented Sep 30, 2020

@tonytitus , merged the PR to master and marked for pick to 201911. You can close this PR

@tonytitus tonytitus closed this Sep 30, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Multi-Db changes for NAT feature. (sonic-net#1202)
[cfgmgr] clear loopback and vrf in kernel if not warmstart (sonic-net#1141)
 upon cold reboot, skip remove mgmt vrf table from the kernel (sonic-net#1214)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
    Multi-Db changes for NAT feature. (sonic-net#1202)
    [cfgmgr] clear loopback and vrf in kernel if not warmstart (sonic-net#1141)
     upon cold reboot, skip remove mgmt vrf table from the kernel (sonic-net#1214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants