[MSTP] Swss Support #3606
[MSTP] Swss Support #3606
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
build fail related to this: sonic-net/sonic-sairedis#1473 (comment) im working on fix for that |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny , Please help to merge the changes |
|
@wajahatrazi , please fix the PR description following the template and provide all the details of the changes. @madhupalu , please review/signoff |
orchagent/orchdaemon.cpp
Outdated
| @@ -1208,7 +1209,7 @@ bool FabricOrchDaemon::init() | |||
| { APP_FABRIC_MONITOR_PORT_TABLE_NAME, fabric_portsorch_base_pri }, | |||
| { APP_FABRIC_MONITOR_DATA_TABLE_NAME, fabric_portsorch_base_pri } | |||
| }; | |||
| gFabricPortsOrch = new FabricPortsOrch(m_applDb, fabric_port_tables); | |||
| gFabricPortsOrch = new FabricPortsOrch(m_applDb, fabric_port_tables, m_fabricPortStatEnabled, m_fabricQueueStatEnabled); | |||
There was a problem hiding this comment.
This change does not seem to be relevant to this PR, please revert.
There was a problem hiding this comment.
It has been reverted
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| msg.stp_mode = L2_MSTP; | ||
|
|
||
| // Assign all VLANs to zero instance for MSTP | ||
| fill_n(m_vlanInstMap, MAX_VLANS, 0); |
There was a problem hiding this comment.
Similarly should port states be initialized for the all ports here?
| { | ||
| msg->portfast = (value == "true") ? 1 : 0; | ||
| } | ||
| else if (field == "uplink_fast") | ||
| else if (field == "uplink_fast" && l2ProtoEnabled ==L2_PVSTP) |
| string op = kfvOp(t); | ||
|
|
||
| string instance = key.substr(13); // Remove "MST_INSTANCE|" prefix | ||
| uint16_t instance_id = static_cast<uint16_t>(stoi(instance.c_str())); |
There was a problem hiding this comment.
should the instance.c_str() be validated?
|
@prsunny @wajahatrazi I have added @sutharsansr from Aviz to review the code. thx |
|
Will review the comments and address |
|
Thanks @madhupalu , @divyachandralekha , @prhoskot for the reviews. @wajahatrazi , merged the PR and thanks for the good contribution. You can address the minor comments in a different PR |
What I did Enhanced the existing stpmgr under cfgmgr to handle MSTP-specific configuration notifications. Added MSTP-related changes in the stporch component to support MSTP operations (MSTI creation/deletion, MSTP Port Add/Update/Delete to MSTI) via SAI APIs. Why I did it To add support for the MSTP (Multiple Spanning Tree Protocol) feature in SONiC.
What I did
Why I did it
How I verified it