Skip to content

Merge vector packet processing (vpp) from sonic-platform-vpp with virtual switch #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 14, 2025

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Nov 24, 2024

Initial attempt

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator Author

kcudnik commented Dec 17, 2024

This is ready for review

Copy link
Contributor

@yue-fred-gao yue-fred-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general. But I think we should wait vpp pipeline ready and verify vpp is able to compile and run.

@kcudnik
Copy link
Collaborator Author

kcudnik commented Dec 17, 2024

This looks good in general. But I think we should wait vpp pipeline ready and verify vpp is able to compile and run.

i just made build from source on azp in sairedis just for test: #1486 if this will succeed, thatn we can just copy that to azpipeline on sonic-platform-vpp if noowne is working on that yet

@kcudnik
Copy link
Collaborator Author

kcudnik commented Dec 18, 2024

seems like vpp build succeeded on azure pipeline: https://dev.azure.com/mssonic/build/_build/results?buildId=724631&view=logs&j=d755766c-c33e-5abe-260c-8d11f335b1a1&t=f2559076-9bdb-5064-4af2-83c32f011787 it took a little bit over 1 hour, first build fialed, nto sure why, but second one after restart succeeded :)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator Author

kcudnik commented Feb 6, 2025

artifacts vpp used from here: #1521

@kcudnik
Copy link
Collaborator Author

kcudnik commented Feb 7, 2025

/azp run

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator Author

kcudnik commented Apr 9, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik kcudnik merged commit 552cc66 into sonic-net:master Apr 14, 2025
14 of 15 checks passed
@kcudnik kcudnik deleted the vppint branch April 14, 2025 06:13
@liuh-80
Copy link
Contributor

liuh-80 commented Apr 15, 2025

Hi @kcudnik , the sonic-swss repo PR validation now failed because vpp missing:

Preparing to unpack .../libsaivs-dev_1.0.0_amd64.deb ...
Unpacking libsaivs-dev (1.0.0) ...
dpkg: dependency problems prevent configuration of libsaivs:
libsaivs depends on libvppinfra; however:
Package libvppinfra is not installed.
libsaivs depends on vpp; however:
Package vpp is not installed.

@kcudnik
Copy link
Collaborator Author

kcudnik commented Apr 15, 2025

Hi @kcudnik , the sonic-swss repo PR validation now failed because vpp missing:

Preparing to unpack .../libsaivs-dev_1.0.0_amd64.deb ... Unpacking libsaivs-dev (1.0.0) ... dpkg: dependency problems prevent configuration of libsaivs: libsaivs depends on libvppinfra; however: Package libvppinfra is not installed. libsaivs depends on vpp; however: Package vpp is not installed.

ahh, i installed this here https://github.com/sonic-net/sonic-sairedis/blob/master/.azure-pipelines/build-swss-template.yml#L148

and the same could be done in swss repo, i can make PR to fix this, but we will have a bigger problem here, since now since sairedis is depending on vpp, we would need need to propagate that in all packages and docker up to buildimage to install vpp, even if it's not required, for example there is no need to install vpp in production images

i think this would need to be discussed and addressed, maybe solution would be to build 2 version of sairedis in pipeline with and without vpp and export artifacts of both ? definitely needs a discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants