-
Notifications
You must be signed in to change notification settings - Fork 294
Merge vector packet processing (vpp) from sonic-platform-vpp with virtual switch #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general. But I think we should wait vpp pipeline ready and verify vpp is able to compile and run.
i just made build from source on azp in sairedis just for test: #1486 if this will succeed, thatn we can just copy that to azpipeline on sonic-platform-vpp if noowne is working on that yet |
seems like vpp build succeeded on azure pipeline: https://dev.azure.com/mssonic/build/_build/results?buildId=724631&view=logs&j=d755766c-c33e-5abe-260c-8d11f335b1a1&t=f2559076-9bdb-5064-4af2-83c32f011787 it took a little bit over 1 hour, first build fialed, nto sure why, but second one after restart succeeded :) |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
artifacts vpp used from here: #1521 |
/azp run |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @kcudnik , the sonic-swss repo PR validation now failed because vpp missing: Preparing to unpack .../libsaivs-dev_1.0.0_amd64.deb ... |
ahh, i installed this here https://github.com/sonic-net/sonic-sairedis/blob/master/.azure-pipelines/build-swss-template.yml#L148 and the same could be done in swss repo, i can make PR to fix this, but we will have a bigger problem here, since now since sairedis is depending on vpp, we would need need to propagate that in all packages and docker up to buildimage to install vpp, even if it's not required, for example there is no need to install vpp in production images i think this would need to be discussed and addressed, maybe solution would be to build 2 version of sairedis in pipeline with and without vpp and export artifacts of both ? definitely needs a discussion |
Initial attempt