-
Notifications
You must be signed in to change notification settings - Fork 121
[sonic-snmpagent] SONiC physical entity mib extension #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9640bc1
SONiC MIB Extension feature first commit
Junchao-Mellanox 625f492
Add unit test cases and fix found issues
Junchao-Mellanox 1228c97
Add more comments
Junchao-Mellanox be0e817
fix issue found in manual tests
Junchao-Mellanox caf96dc
Fix issue found in manual test
Junchao-Mellanox 10569b6
Fix issue: PSU fan is not in entity mib
Junchao-Mellanox b89cde1
Add chassis name and description
Junchao-Mellanox e160479
Change physical index generating rule
Junchao-Mellanox da2adb2
Merge branch 'master' into phy-mibs
Junchao-Mellanox ce9e952
Merge branch 'master' into phy-mibs
Junchao-Mellanox 96d4897
Fix review comment
Junchao-Mellanox 94957eb
Change all bytearray to str
Junchao-Mellanox aa727d5
Move physical_entity_sub_oid_generator to src/sonic_ax_impl/mibs/ietf
Junchao-Mellanox 9f8723b
Fix review comment
Junchao-Mellanox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move non shared functions into rfc2737.py or another python file?
I think many functions and constants are related to the comment section above. Move them into a seperated file may be easier to read. #Closed