Watermark: test SAI clear api if the stats mode is READ_AND_CLEAR #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda <[email protected]>
|
In the title you have "test clear api", and you are adding some log messages with error/notice level, so they will be always visible in the logs, wont that produce a lot of noise in syslog if some of the platform don't support some features ? |
|
Hi Kamil will probe the get_stat and clear_stat function call capability, and remove the stats that are not supported on certain platforms. This ensures that it is less likely the function call will return error during the actual polling phase. |
kcudnik
approved these changes
May 25, 2019
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…onic-net#427) * Test SAI clear api if the stats mode is READ_AND_CLEAR Signed-off-by: Wenda <[email protected]> * Address compile error
jianyuewu
pushed a commit
to jianyuewu/sonic-sairedis
that referenced
this pull request
Feb 7, 2025
) (sonic-net#440) * sonic-utilities: Bug fix while showing interface status for a specific interface. * While getting the keys from port table for a specific interface, wrong db is passed, fixed the bug Signed-off-by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.