Skip to content

FDB meta reference validation error, orchagent crash #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jipanyang opened this issue Mar 29, 2019 · 1 comment
Open

FDB meta reference validation error, orchagent crash #440

jipanyang opened this issue Mar 29, 2019 · 1 comment

Comments

@jipanyang
Copy link
Contributor

meta_fdb_event_snoop_oid() is adding reference for FDB entries with objects bvid and SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID. https://github.com/Azure/sonic-sairedis/pull/420/files

While before "status = sai_bridge_api->remove_bridge_port(port.m_bridge_port_id);"
https://github.com/Azure/sonic-swss/blob/master/orchagent/portsorch.cpp#L2609
no guarantee that all fdb entries have been flushed. meta data validation will fail and cause orchagent to crash.
@jipanyang
Copy link
Contributor Author

A more general question, why are we having void handle_fdb_event(In const std::string &data) in ntf_thread() handling fdb meta data, and fdborch in orchagent processing fdb data. Having them in two threads creates a lot of room for race condition.

Could the fdb meta data handling be moved to fdborch context?

This was referenced Mar 29, 2019
Closed
Open
jianyuewu pushed a commit to jianyuewu/sonic-sairedis that referenced this issue Feb 7, 2025
@kirankella @lguohan
show interface status <interface-name> throws error (fixes sonic-net#427
72b7069 
) (sonic-net#440)

* sonic-utilities: Bug fix while showing interface status for a specific interface.

* While getting the keys from port table for a specific interface, wrong db is passed, fixed the bug

Signed-off-by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jipanyang