-
Notifications
You must be signed in to change notification settings - Fork 181
[ycabled] add support for getting grpc secerts via shared file #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
This pull request introduces 1 alert when merging ee1e109 into 143422b - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question, do we need to store this credential information in CONFIG_DB
? Can we simply read/use only inside ycabled
?
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vaibhav-dahiya <[email protected]>
any reason why to omit the info from |
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
This PR adds support for adding the secrets to grpc client in active-active configuration via a shared file /etc/sonic/grpc_secrets.json. Using this file, secrets configuration in populated inside CONFIG_DB, absence of this file will assume insecure gRPC client. Description Motivation and Context How Has This Been Tested? testing with UT and putting the changes on Arista testbed Signed-off-by: vaibhav-dahiya [email protected]
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
Signed-off-by: vaibhav-dahiya [email protected]
This PR adds support for adding the secrets to grpc client in
active-active
configuration via a shared file/etc/sonic/grpc_secrets.json
.Using this file, secrets configuration in populated inside CONFIG_DB,
absence of this file will assume insecure gRPC client.
Description
Motivation and Context
How Has This Been Tested?
testing with UT and putting the changes on Arista testbed
Additional Information (Optional)