[dualtor-mixed] Set grpc config as insecure for testing #6412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
aa_deploy_mg_grpc_insecure
branch
from
0480397 to
86aadf6
Compare
vdahiya12
reviewed
Sep 26, 2022
Signed-off-by: Longxiang Lyu <[email protected]>
|
@lolyu why did you set the included in 202205 branch flag? This PR hasn't been merged yet. |
|
@lolyu did you test it on a device with and/or with the file to change? Are behaviors in both scenarios good? |
vdahiya12
previously approved these changes
Sep 27, 2022
Signed-off-by: Longxiang Lyu <[email protected]>
Tested, and fix a issue of file parsing. |
bingwang-ms
approved these changes
Sep 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
Oct 8, 2022
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
Approach What is the motivation for this PR? Use insecure config for grpc connections from ycabled in tests. How did you do it? Modify /etc/sonic/grpc_secrets.json How did you verify/test it? This depends on sonic-net/sonic-platform-daemons#298 Any platform specific information? Supported testbed topology if it's a new test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Use
insecureconfig for grpc connections fromycabledin tests.How did you do it?
Modify
/etc/sonic/grpc_secrets.jsonHow did you verify/test it?
This depends on sonic-net/sonic-platform-daemons#298
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation