[ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Junchao-Mellanox can you paste the output of the CLI? |
prgeor
reviewed
Feb 14, 2023
There is no output change: |
liat-grozovik
approved these changes
Feb 15, 2023
|
@prgeor kindly reminder to review following your comments |
|
@prgeor kindly reminder |
prgeor
approved these changes
Feb 27, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2023
…rtium SSD (#344) * [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD * Improve UT cover * Fix UT failure
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-platform-common submodule pointer to include the following: * c551a81 [sonic_ssd] Nokia-7215: Fix show platform ssdhealth ([sonic-net#337](sonic-net/sonic-platform-common#337)) * 1929332 Fix pipeline apt-get purge error. ([sonic-net#349](sonic-net/sonic-platform-common#349)) * 3d57e0e [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD ([sonic-net#344](sonic-net/sonic-platform-common#344)) Signed-off-by: AntonHryshchuk <[email protected]>
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
Jul 11, 2023
…rtium SSD (sonic-net#344) * [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD * Improve UT cover * Fix UT failure
yxieca
pushed a commit
that referenced
this pull request
Sep 12, 2023
… percentage for Virtium SSD (#385) Backport commits: 07ccd27 Fix issue: should use 'Value' column to calculate the health percentage 6d2d7a3 [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD (#344) feb5036 [SSD] deduce vendor name from part number (#322) Description Currently, we are using "Low Raw" column to calculate SSD health, but "Value"column should be used according to vendor document. Motivation and Context Fix issue that SSD health display wrong value How Has This Been Tested? Manual test Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For virtium SSD, sometimes there is no NAND_Endurance and Average_Erase_Count field in SSD smart attributes. We should use Remaining_Life_Left in such case.
Motivation and Context
To support SSD health on more virtium SSD
How Has This Been Tested?
Manual test
Unit test
Additional Information (Optional)