[SSD] deduce vendor name from part number for Virtium #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Nov 14, 2022
liat-grozovik
approved these changes
Nov 14, 2022
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
Jul 11, 2023
- Description Deduce SSD vendor name from part number for Virtum - Motivation and Context Currently, ssd_generic.py deduce vendor name by smartctl command. For example, Device Model: StorFly VSFDM8XC240G-V11-T "StorFly" is the vendor name. However, for some SSD vendor, smartctl cannot get vendor name. For example: Device Model: VSFDM8XC240G-V11-T In such case, vendor name shall be deduced from part number.
yxieca
pushed a commit
that referenced
this pull request
Sep 12, 2023
… percentage for Virtium SSD (#385) Backport commits: 07ccd27 Fix issue: should use 'Value' column to calculate the health percentage 6d2d7a3 [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD (#344) feb5036 [SSD] deduce vendor name from part number (#322) Description Currently, we are using "Low Raw" column to calculate SSD health, but "Value"column should be used according to vendor document. Motivation and Context Fix issue that SSD health display wrong value How Has This Been Tested? Manual test Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deduce SSD vendor name from part number for Virtum
Motivation and Context
Currently, ssd_generic.py deduce vendor name by
smartctlcommand. For example,"StorFly" is the vendor name. However, for some SSD vendor,
smartctlcannot get vendor name. For example:In such case, vendor name shall be deduced from part number.
How Has This Been Tested?
Additional Information (Optional)