-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[barefoot][platform] Refactor chassis.py #7704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request fixes 2 alerts when merging b22157154a06ba4511d97097d65eea73a943d3a4 into 9930e73 - view on LGTM.com fixed alerts:
|
b221571
to
2dcfb6a
Compare
This pull request fixes 2 alerts when merging 2dcfb6a61ed3d39a1373807f1fbb1003195f9f72 into 9930e73 - view on LGTM.com fixed alerts:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 7704 in repo Azure/sonic-buildimage |
2dcfb6a
to
91c933c
Compare
This pull request fixes 2 alerts when merging 91c933ce673312da66127db88b28af40e8b50f5d into a42aa3d - view on LGTM.com fixed alerts:
|
91c933c
to
59e40ee
Compare
This pull request fixes 2 alerts when merging 59e40eeb0e86edb6dde948b67a7933b1293740df into bf21dbc - view on LGTM.com fixed alerts:
|
59e40ee
to
bacab9e
Compare
This pull request fixes 2 alerts when merging bacab9e2b0d258be6e172b0783ddf30ef9fe5a4a into 1324200 - view on LGTM.com fixed alerts:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
bacab9e
to
bbb8c79
Compare
This pull request fixes 2 alerts when merging bbb8c79dcf335411594d45f943703f8c2faf3e60 into 3ad4f79 - view on LGTM.com fixed alerts:
|
bbb8c79
to
2a5d290
Compare
This pull request fixes 2 alerts when merging 2a5d2908bc0c7f573d48326b6ab790ef1b26195b into b30cf44 - view on LGTM.com fixed alerts:
|
Signed-off-by: Volodymyr Boyko <[email protected]>
2a5d290
to
db2fc70
Compare
This pull request fixes 2 alerts when merging db2fc70 into 5366333 - view on LGTM.com fixed alerts:
|
This could not be cleanly cherry-picked to 202012. Please submit another PR. |
@qiluo-msft Please cherry-pick this PR first: #7103 |
#### Why I did it On our platforms syncd must be up while using the sonic_platform. The issue is warm-reboot script first disables syncd then instantiate Chassis, which tries to connect syncd in __init__. #### How I did it Refactor Chassis to lazy initialize components. Signed-off-by: Volodymyr Boyko <[email protected]>
#### Why I did it On our platforms syncd must be up while using the sonic_platform. The issue is warm-reboot script first disables syncd then instantiate Chassis, which tries to connect syncd in __init__. #### How I did it Refactor Chassis to lazy initialize components. Signed-off-by: Volodymyr Boyko <[email protected]>
Signed-off-by: Volodymyr Boyko [email protected]
Why I did it
On our platforms syncd must be up while using the sonic_platform.
The issue is warm-reboot script first disables syncd then instantiate Chassis, which tries to connect syncd in init.
How I did it
Refactor Chassis to lazy initialize components.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)