Skip to content

[platform][barefoot] Lazy initialize fans and thermals list #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

vboykox
Copy link
Member

@vboykox vboykox commented Mar 19, 2021

Signed-off-by: Volodymyr Boyko [email protected]

Why I did it

In order to reduce Chassis object initialization time

How I did it

Initialize fans and thermals lists on demand; make them properties

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

Initialize fans and thermals lists on demand to reduce Chassis object initialization time

A picture of a cute animal (not mandatory but encouraged)

@vboykox vboykox requested a review from lguohan as a code owner March 19, 2021 08:23
@vboykox vboykox force-pushed the fix_long_chassis_time branch 2 times, most recently from 630e90b to bb39b04 Compare March 19, 2021 09:12
akokhan
akokhan previously approved these changes Mar 19, 2021
@vboykox
Copy link
Member Author

vboykox commented Mar 19, 2021

@jleveque

jleveque
jleveque previously approved these changes Mar 19, 2021
@vboykox
Copy link
Member Author

vboykox commented Mar 23, 2021

@jleveque

jleveque
jleveque previously approved these changes Mar 23, 2021
@vboykox vboykox force-pushed the fix_long_chassis_time branch 2 times, most recently from 2d312bd to f247751 Compare March 24, 2021 21:30
@vboykox vboykox requested a review from jleveque March 24, 2021 21:31
jleveque
jleveque previously approved these changes Mar 24, 2021
@vboykox vboykox force-pushed the fix_long_chassis_time branch from b251b7f to ac74f50 Compare March 25, 2021 20:39
@vboykox vboykox requested a review from jleveque March 26, 2021 09:19
@jleveque jleveque merged commit e1d8d18 into sonic-net:master Mar 26, 2021
@yxieca
Copy link
Contributor

yxieca commented Mar 26, 2021

@jleveque @vboykox this change cannot be cherry picked to 202012 cleanly. Please re-assess the need of this change in 202012 branch. If it is needed. please open PR for 202012 branch directly.

@jleveque
Copy link
Contributor

@vboykox: Is it possible that there are other commits which need to be cherry-picked to 202012 first? If so, please identify them.

@vboykox
Copy link
Member Author

vboykox commented Mar 29, 2021

@jleveque @yxieca looks like this commit https://github.com/Azure/sonic-buildimage/pull/7004/files wasn't picked in 202012

@vboykox vboykox deleted the fix_long_chassis_time branch March 29, 2021 05:10
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
…t#7103)

Initialize fans and thermals lists on demand; make them properties in order to reduce Chassis object initialization time

Signed-off-by: Volodymyr Boyko <[email protected]>
qiluo-msft pushed a commit that referenced this pull request Jun 9, 2021
Initialize fans and thermals lists on demand; make them properties in order to reduce Chassis object initialization time

Signed-off-by: Volodymyr Boyko <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…t#7103)

Initialize fans and thermals lists on demand; make them properties in order to reduce Chassis object initialization time

Signed-off-by: Volodymyr Boyko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants