Skip to content

[ntp]: Use loopback address when we don't have MGMT interface #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

pavel-shirshov
Copy link
Contributor

- What I did
Added configuration to use Loopback ip if a switch doesn't have MGMT_PORT.

- How I did it
Add extra "if" in ntp.conf template.

- How to verify it
Build an image and run on your DUT.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov
Copy link
Contributor Author

Please check comments here #1035

@pavel-shirshov pavel-shirshov requested a review from lguohan October 4, 2019 23:15
@lguohan lguohan merged commit 9b8f5c9 into sonic-net:master Oct 7, 2019
yxieca pushed a commit that referenced this pull request Oct 7, 2019
Added configuration to use Loopback ip if a switch doesn't have MGMT_PORT.
@pavel-shirshov pavel-shirshov deleted the pavelsh/fix_ntp branch October 7, 2019 19:39
mssonicbld added a commit that referenced this pull request Mar 21, 2025
…atically (#22026)

#### Why I did it
src/sonic-utilities
```
* 6e93f44 - (HEAD -> master, origin/master, origin/HEAD) Add Arista-7060X6-64PE-C224O8, Arista-7060X6-64PE-C256S2 to generic_config_updater (#3804) (18 hours ago) [rick-arista]
* 208474c - Add scope to field validator.[redo PR: 3675] (#3805) (2 days ago) [Xincun Li]
* a363c7f - [SmartSwitch] Extend reboot script for rebooting SmartSwitch (#3566) (6 days ago) [Vasundhara Volam]
* 5e3b132 - [hash] update GH frontend with IPV6_FLOW_LABEL for ECMP/LAG switch hash configuration (#3730) (7 days ago) [Andriy Yurkiv]
* 706f97e - [Techsupport] Add show route-map command to frr dumps in techsupport (#3797) (7 days ago) [Sudharsan Dhamal Gopalarathnam]
* 1ec0540 - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (#3769) (7 days ago) [saksarav-nokia]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Apr 19, 2025
…lly (#22378)

#### Why I did it
src/sonic-swss
```
* e0b2ac61 - (HEAD -> master, origin/master, origin/HEAD) swss: Align STP structures and remove GCC diagnostic pragmas (#3440) (3 hours ago) [Omar Tamer]
* 120ed90a - [fgnhgorch] Fix incorrect state DB updates due to unordered field-val… (#3566) (3 hours ago) [InspurSDN]
* 1552e340 - Move timestamps out of counter table to avoid update too frequently (#3585) (6 hours ago) [Stephen Sun]
* 73e534c3 - Initialize the last fec ber computed values if not found (#3604) (27 hours ago) [Prince George]
* 504daa19 - [az] Install vpp artifacts (#3609) (27 hours ago) [Kamil Cudnik]
* bc750a5a - [orchagent] Add value validation for RouteOrch, NhgOrch and Srv6Orch (#3596) (4 days ago) [Yuqing Zhao(Alibaba Inc)]
* d1fb9f7f - [DASH] Dash tunnel/PL NSG implementation (#3543) (4 days ago) [Lawrence Lee]
* ffc865e6 - Fix a pipeline issue due to dependency in docker-sonic-vs (#3603) (4 days ago) [Dashuai Zhang]
* f7ca83d2 - Fix the missed port status notifications issue (#3595) (7 days ago) [Vivek]
* 5592fbe0 - [portsorch] pass oper status at hostif creation (#3563) (7 days ago) [Stepan Blyshchak]
* 7bcd21c7 - [orchagent] Fix issue: typo in high BER (#3600) (8 days ago) [Junchao-Mellanox]
* 3e1f8d8f - [portmgrd] regression: prevent runtime exception (crash) in configuring portchannel at boot (#3432) (8 days ago) [Brad House]
* 492a85ae - [DASH] Make DASH vnet orch bulk logic consistent (#3554) (2 weeks ago) [Lawrence Lee]
* 822ab913 - Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE (#3571) (3 weeks ago) [prabhataravind]
* fe9b89e4 - [DVS] Remove framework package during DVS build (#3577) (3 weeks ago) [Lawrence Lee]
* 596d88c1 - Added Change for given Route ECMP to fallback on Default Route ECMP (#3389) (3 weeks ago) [abdosi]
* d35c1c77 - Initialize number of counters to 0 before querying the capabilities (#3546) (5 weeks ago) [Stephen Sun]
* 0e0685ae - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (#3521) (5 weeks ago) [saksarav-nokia]
* ee38b39e - [BFD] Change capability check to get. (#3559) (5 weeks ago) [dypet]
* 45fdedb9 - Prevent lossless profile creation for 0m cable (#3548) (5 weeks ago) [Jianyue Wu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
yanjundeng pushed a commit to yanjundeng/sonic-buildimage that referenced this pull request Apr 23, 2025
…atically (sonic-net#22026)

#### Why I did it
src/sonic-utilities
```
* 6e93f44 - (HEAD -> master, origin/master, origin/HEAD) Add Arista-7060X6-64PE-C224O8, Arista-7060X6-64PE-C256S2 to generic_config_updater (sonic-net#3804) (18 hours ago) [rick-arista]
* 208474c - Add scope to field validator.[redo PR: 3675] (sonic-net#3805) (2 days ago) [Xincun Li]
* a363c7f - [SmartSwitch] Extend reboot script for rebooting SmartSwitch (sonic-net#3566) (6 days ago) [Vasundhara Volam]
* 5e3b132 - [hash] update GH frontend with IPV6_FLOW_LABEL for ECMP/LAG switch hash configuration (sonic-net#3730) (7 days ago) [Andriy Yurkiv]
* 706f97e - [Techsupport] Add show route-map command to frr dumps in techsupport (sonic-net#3797) (7 days ago) [Sudharsan Dhamal Gopalarathnam]
* 1ec0540 - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (sonic-net#3769) (7 days ago) [saksarav-nokia]
```
#### How I did it
#### How to verify it
#### Description for the changelog
yanjundeng pushed a commit to yanjundeng/sonic-buildimage that referenced this pull request Apr 23, 2025
…lly (sonic-net#22378)

#### Why I did it
src/sonic-swss
```
* e0b2ac61 - (HEAD -> master, origin/master, origin/HEAD) swss: Align STP structures and remove GCC diagnostic pragmas (sonic-net#3440) (3 hours ago) [Omar Tamer]
* 120ed90a - [fgnhgorch] Fix incorrect state DB updates due to unordered field-val… (sonic-net#3566) (3 hours ago) [InspurSDN]
* 1552e340 - Move timestamps out of counter table to avoid update too frequently (sonic-net#3585) (6 hours ago) [Stephen Sun]
* 73e534c3 - Initialize the last fec ber computed values if not found (sonic-net#3604) (27 hours ago) [Prince George]
* 504daa19 - [az] Install vpp artifacts (sonic-net#3609) (27 hours ago) [Kamil Cudnik]
* bc750a5a - [orchagent] Add value validation for RouteOrch, NhgOrch and Srv6Orch (sonic-net#3596) (4 days ago) [Yuqing Zhao(Alibaba Inc)]
* d1fb9f7f - [DASH] Dash tunnel/PL NSG implementation (sonic-net#3543) (4 days ago) [Lawrence Lee]
* ffc865e6 - Fix a pipeline issue due to dependency in docker-sonic-vs (sonic-net#3603) (4 days ago) [Dashuai Zhang]
* f7ca83d2 - Fix the missed port status notifications issue (sonic-net#3595) (7 days ago) [Vivek]
* 5592fbe0 - [portsorch] pass oper status at hostif creation (sonic-net#3563) (7 days ago) [Stepan Blyshchak]
* 7bcd21c7 - [orchagent] Fix issue: typo in high BER (sonic-net#3600) (8 days ago) [Junchao-Mellanox]
* 3e1f8d8f - [portmgrd] regression: prevent runtime exception (crash) in configuring portchannel at boot (sonic-net#3432) (8 days ago) [Brad House]
* 492a85ae - [DASH] Make DASH vnet orch bulk logic consistent (sonic-net#3554) (2 weeks ago) [Lawrence Lee]
* 822ab913 - Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE (sonic-net#3571) (3 weeks ago) [prabhataravind]
* fe9b89e4 - [DVS] Remove framework package during DVS build (sonic-net#3577) (3 weeks ago) [Lawrence Lee]
* 596d88c1 - Added Change for given Route ECMP to fallback on Default Route ECMP (sonic-net#3389) (3 weeks ago) [abdosi]
* d35c1c77 - Initialize number of counters to 0 before querying the capabilities (sonic-net#3546) (5 weeks ago) [Stephen Sun]
* 0e0685ae - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (sonic-net#3521) (5 weeks ago) [saksarav-nokia]
* ee38b39e - [BFD] Change capability check to get. (sonic-net#3559) (5 weeks ago) [dypet]
* 45fdedb9 - Prevent lossless profile creation for 0m cable (sonic-net#3548) (5 weeks ago) [Jianyue Wu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
vidyac86 pushed a commit to vidyac86/sonic-buildimage that referenced this pull request Apr 23, 2025
…lly (sonic-net#22378)

#### Why I did it
src/sonic-swss
```
* e0b2ac61 - (HEAD -> master, origin/master, origin/HEAD) swss: Align STP structures and remove GCC diagnostic pragmas (sonic-net#3440) (3 hours ago) [Omar Tamer]
* 120ed90a - [fgnhgorch] Fix incorrect state DB updates due to unordered field-val… (sonic-net#3566) (3 hours ago) [InspurSDN]
* 1552e340 - Move timestamps out of counter table to avoid update too frequently (sonic-net#3585) (6 hours ago) [Stephen Sun]
* 73e534c3 - Initialize the last fec ber computed values if not found (sonic-net#3604) (27 hours ago) [Prince George]
* 504daa19 - [az] Install vpp artifacts (sonic-net#3609) (27 hours ago) [Kamil Cudnik]
* bc750a5a - [orchagent] Add value validation for RouteOrch, NhgOrch and Srv6Orch (sonic-net#3596) (4 days ago) [Yuqing Zhao(Alibaba Inc)]
* d1fb9f7f - [DASH] Dash tunnel/PL NSG implementation (sonic-net#3543) (4 days ago) [Lawrence Lee]
* ffc865e6 - Fix a pipeline issue due to dependency in docker-sonic-vs (sonic-net#3603) (4 days ago) [Dashuai Zhang]
* f7ca83d2 - Fix the missed port status notifications issue (sonic-net#3595) (7 days ago) [Vivek]
* 5592fbe0 - [portsorch] pass oper status at hostif creation (sonic-net#3563) (7 days ago) [Stepan Blyshchak]
* 7bcd21c7 - [orchagent] Fix issue: typo in high BER (sonic-net#3600) (8 days ago) [Junchao-Mellanox]
* 3e1f8d8f - [portmgrd] regression: prevent runtime exception (crash) in configuring portchannel at boot (sonic-net#3432) (8 days ago) [Brad House]
* 492a85ae - [DASH] Make DASH vnet orch bulk logic consistent (sonic-net#3554) (2 weeks ago) [Lawrence Lee]
* 822ab913 - Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE (sonic-net#3571) (3 weeks ago) [prabhataravind]
* fe9b89e4 - [DVS] Remove framework package during DVS build (sonic-net#3577) (3 weeks ago) [Lawrence Lee]
* 596d88c1 - Added Change for given Route ECMP to fallback on Default Route ECMP (sonic-net#3389) (3 weeks ago) [abdosi]
* d35c1c77 - Initialize number of counters to 0 before querying the capabilities (sonic-net#3546) (5 weeks ago) [Stephen Sun]
* 0e0685ae - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (sonic-net#3521) (5 weeks ago) [saksarav-nokia]
* ee38b39e - [BFD] Change capability check to get. (sonic-net#3559) (5 weeks ago) [dypet]
* 45fdedb9 - Prevent lossless profile creation for 0m cable (sonic-net#3548) (5 weeks ago) [Jianyue Wu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants