-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[makefile] build Jessie slave unless NOJESSIE is specified #3546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <[email protected]>
qiluo-msft
approved these changes
Oct 1, 2019
jleveque
approved these changes
Oct 1, 2019
jleveque
approved these changes
Oct 2, 2019
retest vsimage please |
qiluo-msft
reviewed
Oct 2, 2019
@@ -17,4 +17,7 @@ endif | |||
|
|||
clean reset init configure showtag sonic-slave-build sonic-slave-bash : | |||
@echo "+++ Making $@ +++" | |||
ifeq ($(NOJESSIE), 0) | |||
make -f Makefile.work $@ | |||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if-else-endif ?
sschlafman
pushed a commit
to sschlafman/sonic-buildimage
that referenced
this pull request
Oct 15, 2024
…atically (sonic-net#20458) #### Why I did it src/sonic-utilities ``` * 910252c - (HEAD -> master, origin/master, origin/HEAD) [Mellanox] Rename SKU to Mellanox-SN5600-C256X1 (sonic-net#3546) (3 days ago) [DavidZagury] ``` #### How I did it #### How to verify it #### Description for the changelog
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…atically (sonic-net#20458) #### Why I did it src/sonic-utilities ``` * 910252c - (HEAD -> master, origin/master, origin/HEAD) [Mellanox] Rename SKU to Mellanox-SN5600-C256X1 (sonic-net#3546) (3 days ago) [DavidZagury] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Apr 19, 2025
…lly (#22378) #### Why I did it src/sonic-swss ``` * e0b2ac61 - (HEAD -> master, origin/master, origin/HEAD) swss: Align STP structures and remove GCC diagnostic pragmas (#3440) (3 hours ago) [Omar Tamer] * 120ed90a - [fgnhgorch] Fix incorrect state DB updates due to unordered field-val… (#3566) (3 hours ago) [InspurSDN] * 1552e340 - Move timestamps out of counter table to avoid update too frequently (#3585) (6 hours ago) [Stephen Sun] * 73e534c3 - Initialize the last fec ber computed values if not found (#3604) (27 hours ago) [Prince George] * 504daa19 - [az] Install vpp artifacts (#3609) (27 hours ago) [Kamil Cudnik] * bc750a5a - [orchagent] Add value validation for RouteOrch, NhgOrch and Srv6Orch (#3596) (4 days ago) [Yuqing Zhao(Alibaba Inc)] * d1fb9f7f - [DASH] Dash tunnel/PL NSG implementation (#3543) (4 days ago) [Lawrence Lee] * ffc865e6 - Fix a pipeline issue due to dependency in docker-sonic-vs (#3603) (4 days ago) [Dashuai Zhang] * f7ca83d2 - Fix the missed port status notifications issue (#3595) (7 days ago) [Vivek] * 5592fbe0 - [portsorch] pass oper status at hostif creation (#3563) (7 days ago) [Stepan Blyshchak] * 7bcd21c7 - [orchagent] Fix issue: typo in high BER (#3600) (8 days ago) [Junchao-Mellanox] * 3e1f8d8f - [portmgrd] regression: prevent runtime exception (crash) in configuring portchannel at boot (#3432) (8 days ago) [Brad House] * 492a85ae - [DASH] Make DASH vnet orch bulk logic consistent (#3554) (2 weeks ago) [Lawrence Lee] * 822ab913 - Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE (#3571) (3 weeks ago) [prabhataravind] * fe9b89e4 - [DVS] Remove framework package during DVS build (#3577) (3 weeks ago) [Lawrence Lee] * 596d88c1 - Added Change for given Route ECMP to fallback on Default Route ECMP (#3389) (3 weeks ago) [abdosi] * d35c1c77 - Initialize number of counters to 0 before querying the capabilities (#3546) (5 weeks ago) [Stephen Sun] * 0e0685ae - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (#3521) (5 weeks ago) [saksarav-nokia] * ee38b39e - [BFD] Change capability check to get. (#3559) (5 weeks ago) [dypet] * 45fdedb9 - Prevent lossless profile creation for 0m cable (#3548) (5 weeks ago) [Jianyue Wu] ``` #### How I did it #### How to verify it #### Description for the changelog
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…atically (sonic-net#20458) #### Why I did it src/sonic-utilities ``` * 910252c - (HEAD -> master, origin/master, origin/HEAD) [Mellanox] Rename SKU to Mellanox-SN5600-C256X1 (sonic-net#3546) (3 days ago) [DavidZagury] ``` #### How I did it #### How to verify it #### Description for the changelog
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…lly (sonic-net#22378) #### Why I did it src/sonic-swss ``` * e0b2ac61 - (HEAD -> master, origin/master, origin/HEAD) swss: Align STP structures and remove GCC diagnostic pragmas (sonic-net#3440) (3 hours ago) [Omar Tamer] * 120ed90a - [fgnhgorch] Fix incorrect state DB updates due to unordered field-val… (sonic-net#3566) (3 hours ago) [InspurSDN] * 1552e340 - Move timestamps out of counter table to avoid update too frequently (sonic-net#3585) (6 hours ago) [Stephen Sun] * 73e534c3 - Initialize the last fec ber computed values if not found (sonic-net#3604) (27 hours ago) [Prince George] * 504daa19 - [az] Install vpp artifacts (sonic-net#3609) (27 hours ago) [Kamil Cudnik] * bc750a5a - [orchagent] Add value validation for RouteOrch, NhgOrch and Srv6Orch (sonic-net#3596) (4 days ago) [Yuqing Zhao(Alibaba Inc)] * d1fb9f7f - [DASH] Dash tunnel/PL NSG implementation (sonic-net#3543) (4 days ago) [Lawrence Lee] * ffc865e6 - Fix a pipeline issue due to dependency in docker-sonic-vs (sonic-net#3603) (4 days ago) [Dashuai Zhang] * f7ca83d2 - Fix the missed port status notifications issue (sonic-net#3595) (7 days ago) [Vivek] * 5592fbe0 - [portsorch] pass oper status at hostif creation (sonic-net#3563) (7 days ago) [Stepan Blyshchak] * 7bcd21c7 - [orchagent] Fix issue: typo in high BER (sonic-net#3600) (8 days ago) [Junchao-Mellanox] * 3e1f8d8f - [portmgrd] regression: prevent runtime exception (crash) in configuring portchannel at boot (sonic-net#3432) (8 days ago) [Brad House] * 492a85ae - [DASH] Make DASH vnet orch bulk logic consistent (sonic-net#3554) (2 weeks ago) [Lawrence Lee] * 822ab913 - Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE (sonic-net#3571) (3 weeks ago) [prabhataravind] * fe9b89e4 - [DVS] Remove framework package during DVS build (sonic-net#3577) (3 weeks ago) [Lawrence Lee] * 596d88c1 - Added Change for given Route ECMP to fallback on Default Route ECMP (sonic-net#3389) (3 weeks ago) [abdosi] * d35c1c77 - Initialize number of counters to 0 before querying the capabilities (sonic-net#3546) (5 weeks ago) [Stephen Sun] * 0e0685ae - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (sonic-net#3521) (5 weeks ago) [saksarav-nokia] * ee38b39e - [BFD] Change capability check to get. (sonic-net#3559) (5 weeks ago) [dypet] * 45fdedb9 - Prevent lossless profile creation for 0m cable (sonic-net#3548) (5 weeks ago) [Jianyue Wu] ``` #### How I did it #### How to verify it #### Description for the changelog
vidyac86
pushed a commit
to vidyac86/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…lly (sonic-net#22378) #### Why I did it src/sonic-swss ``` * e0b2ac61 - (HEAD -> master, origin/master, origin/HEAD) swss: Align STP structures and remove GCC diagnostic pragmas (sonic-net#3440) (3 hours ago) [Omar Tamer] * 120ed90a - [fgnhgorch] Fix incorrect state DB updates due to unordered field-val… (sonic-net#3566) (3 hours ago) [InspurSDN] * 1552e340 - Move timestamps out of counter table to avoid update too frequently (sonic-net#3585) (6 hours ago) [Stephen Sun] * 73e534c3 - Initialize the last fec ber computed values if not found (sonic-net#3604) (27 hours ago) [Prince George] * 504daa19 - [az] Install vpp artifacts (sonic-net#3609) (27 hours ago) [Kamil Cudnik] * bc750a5a - [orchagent] Add value validation for RouteOrch, NhgOrch and Srv6Orch (sonic-net#3596) (4 days ago) [Yuqing Zhao(Alibaba Inc)] * d1fb9f7f - [DASH] Dash tunnel/PL NSG implementation (sonic-net#3543) (4 days ago) [Lawrence Lee] * ffc865e6 - Fix a pipeline issue due to dependency in docker-sonic-vs (sonic-net#3603) (4 days ago) [Dashuai Zhang] * f7ca83d2 - Fix the missed port status notifications issue (sonic-net#3595) (7 days ago) [Vivek] * 5592fbe0 - [portsorch] pass oper status at hostif creation (sonic-net#3563) (7 days ago) [Stepan Blyshchak] * 7bcd21c7 - [orchagent] Fix issue: typo in high BER (sonic-net#3600) (8 days ago) [Junchao-Mellanox] * 3e1f8d8f - [portmgrd] regression: prevent runtime exception (crash) in configuring portchannel at boot (sonic-net#3432) (8 days ago) [Brad House] * 492a85ae - [DASH] Make DASH vnet orch bulk logic consistent (sonic-net#3554) (2 weeks ago) [Lawrence Lee] * 822ab913 - Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE (sonic-net#3571) (3 weeks ago) [prabhataravind] * fe9b89e4 - [DVS] Remove framework package during DVS build (sonic-net#3577) (3 weeks ago) [Lawrence Lee] * 596d88c1 - Added Change for given Route ECMP to fallback on Default Route ECMP (sonic-net#3389) (3 weeks ago) [abdosi] * d35c1c77 - Initialize number of counters to 0 before querying the capabilities (sonic-net#3546) (5 weeks ago) [Stephen Sun] * 0e0685ae - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (sonic-net#3521) (5 weeks ago) [saksarav-nokia] * ee38b39e - [BFD] Change capability check to get. (sonic-net#3559) (5 weeks ago) [dypet] * 45fdedb9 - Prevent lossless profile creation for 0m cable (sonic-net#3548) (5 weeks ago) [Jianyue Wu] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a method in master branch to build Jessie slave docker. This option is currently on by default unless NOJESSIE=1 is specified. The default for NOJESSIE should probably becomes 1 at some point when we fully understand what needs Jessie slave docker where from the master branch.