Skip to content

[202411] Revert "Mount the /tmp directory as tmpfs" #22080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

lizhijianrd
Copy link
Contributor

@lizhijianrd lizhijianrd commented Mar 19, 2025

Why I did it

Revert "Mount the /tmp directory as tmpfs" on 202411 branch. It was introduced by PR #20640.
We need to reconsider the impact to memory utilization of "Mount the /tmp directory as tmpfs". Especially on the platforms with low memory capacity.

Work item tracking
  • Microsoft ADO (number only): 31874093

How I did it

Update mount j2 template.

How to verify it

  1. Verified by PR test.
  2. Install the image built by PR test on DUT, confirmed /tmp is not mount on tmpfs
admin@sonic:~$ df -h /tmp
Filesystem      Size  Used Avail Use% Mounted on
root-overlay     15G  5.1G  9.2G  36% /

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lizhijianrd lizhijianrd requested a review from lguohan as a code owner March 19, 2025 07:29
@lizhijianrd lizhijianrd requested a review from Blueve March 19, 2025 07:31
@lizhijianrd
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 22080 in repo sonic-net/sonic-buildimage

@lizhijianrd
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lizhijianrd lizhijianrd reopened this Mar 19, 2025
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam
Copy link
Contributor

vvolam commented Mar 20, 2025

@lizhijianrd Could you please update PR description with original PR that added the changes? This way we can easily look at the history?

@vvolam vvolam self-requested a review March 20, 2025 16:48
@lizhijianrd
Copy link
Contributor Author

@lizhijianrd Could you please update PR description with original PR that added the changes? This way we can easily look at the history?

Hi @vvolam, here is the original PR #20640. Updated in my PR desc too. Thanks.

@kperumalbfn kperumalbfn merged commit 855e80d into sonic-net:202411 Mar 21, 2025
22 checks passed
@kperumalbfn
Copy link
Contributor

@lizhijianrd @vvolam should we revert the whole PR in 202411 instead of point fix?

@vvolam
Copy link
Contributor

vvolam commented Mar 21, 2025

@kperumalbfn I have looked at earlier patch, remaining changes in prior fix is improvements to different areas and should not impact the memory.

@kperumalbfn
Copy link
Contributor

Thanks @vvolam

@lizhijianrd lizhijianrd deleted the 202411-revert-tmp-tmpfs branch March 21, 2025 21:54
Gfrom2016 pushed a commit to Gfrom2016/sonic-buildimage that referenced this pull request Apr 5, 2025
…-net#960)

Code sync sonic-net/sonic-buildimage:202411 => 202412

```
*   875852e (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250330:2343 - Merge remote-tracking branch 'base/202411' into code-sync-202412
|\  
| * e523d51 (base/202411) mssonicbld 250329:0401 - Fix auditd container monit startup issue (sonic-net#22012)
| * 0615c4a mssonicbld 250329:0325 - [installer] Add CSTATE configuration for the AMD CPU. (sonic-net#22060)
| * 606ff68 mssonicbld 250328:1601 - [submodule] Update submodule sonic-swss to the latest HEAD automatically (sonic-net#22159)
| * fb36404 Aravind-Subbaroyan 250326:1714 - Update cisco-8000.ini (sonic-net#22154)
| * 869a801 mssonicbld 250325:1901 - [submodule] Update submodule sonic-utilities to the latest HEAD automatically (sonic-net#22127)
| * 81af0af mssonicbld 250325:1601 - [chassis][multi-asic]: Add support for vendor LC ip range for macvlan ip (sonic-net#22125)
| * a4f5972 sschlafman 250321:1508 - [202411] Add new T1 Mellanox-SN4280-O8C40 SKU for 202411 (sonic-net#22103)
| * b945441 mssonicbld 250322:0516 - [submodule] Update submodule sonic-sairedis to the latest HEAD automatically (sonic-net#22090)
| * cac6efb Dror Prital 250321:1846 - [202411][Mellanox] Update SDK/FW Version to 4.7.2214/2014.2214 (sonic-net#22097)
| * 855e80d Zhijian Li 250322:0213 - [202411] Revert "Mount the /tmp directory as tmpfs" (sonic-net#22080)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants