Skip to content

[action] [PR:22006] [installer] Add CSTATE configuration for the AMD CPU. #22060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

mssonicbld
Copy link
Collaborator

Why I did it

Add CSTATE configuration for the AMD CPU to disable CPU idling.
Related to: #16339

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add processor.max_cstate=1 amd_idle.max_cstate=0 to installer default grub config.

How to verify it

Boot the image. Verify the added option are present in cat /proc/cmdline command output.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
Add CSTATE configuration for the AMD CPU to disable CPU idling.
Related to: sonic-net#16339

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Add `processor.max_cstate=1 amd_idle.max_cstate=0` to installer default grub config.

#### How to verify it
Boot the image. Verify the added option are present in `cat /proc/cmdline` command output.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@mssonicbld
Copy link
Collaborator Author

Original PR: #22006

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn kperumalbfn merged commit 0615c4a into sonic-net:202411 Mar 28, 2025
19 checks passed
Gfrom2016 pushed a commit to Gfrom2016/sonic-buildimage that referenced this pull request Apr 5, 2025
…-net#960)

Code sync sonic-net/sonic-buildimage:202411 => 202412

```
*   875852e (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250330:2343 - Merge remote-tracking branch 'base/202411' into code-sync-202412
|\  
| * e523d51 (base/202411) mssonicbld 250329:0401 - Fix auditd container monit startup issue (sonic-net#22012)
| * 0615c4a mssonicbld 250329:0325 - [installer] Add CSTATE configuration for the AMD CPU. (sonic-net#22060)
| * 606ff68 mssonicbld 250328:1601 - [submodule] Update submodule sonic-swss to the latest HEAD automatically (sonic-net#22159)
| * fb36404 Aravind-Subbaroyan 250326:1714 - Update cisco-8000.ini (sonic-net#22154)
| * 869a801 mssonicbld 250325:1901 - [submodule] Update submodule sonic-utilities to the latest HEAD automatically (sonic-net#22127)
| * 81af0af mssonicbld 250325:1601 - [chassis][multi-asic]: Add support for vendor LC ip range for macvlan ip (sonic-net#22125)
| * a4f5972 sschlafman 250321:1508 - [202411] Add new T1 Mellanox-SN4280-O8C40 SKU for 202411 (sonic-net#22103)
| * b945441 mssonicbld 250322:0516 - [submodule] Update submodule sonic-sairedis to the latest HEAD automatically (sonic-net#22090)
| * cac6efb Dror Prital 250321:1846 - [202411][Mellanox] Update SDK/FW Version to 4.7.2214/2014.2214 (sonic-net#22097)
| * 855e80d Zhijian Li 250322:0213 - [202411] Revert "Mount the /tmp directory as tmpfs" (sonic-net#22080)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants